Resolves no such file error when deleting item (#8239)

keystonejs · Jan 11, 2023 · ebd7259 · ebd7259 · vercel · Jan 11, 2023
1 parent bfc3596
commit ebd7259
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/.changeset/gentle-poets-perform.md b/.changeset/gentle-poets-perform.md
@@ -0,0 +1,5 @@
+---
+'@keystone-6/core': patch
+---
+
+Resolves error when deleting an item that has a file or image that is no longer on the filesystem
diff --git a/packages/core/src/lib/assets/local.ts b/packages/core/src/lib/assets/local.ts
@@ -19,7 +19,15 @@ export function localImageAssetsAPI(
       await fs.writeFile(path.join(storageConfig.storagePath, `${id}.${extension}`), buffer);
     },
     async delete(id, extension) {
-      await fs.unlink(path.join(storageConfig.storagePath, `${id}.${extension}`));
+      try {
+        await fs.unlink(path.join(storageConfig.storagePath, `${id}.${extension}`));
+      } catch (e) {
+        const error = e as NodeJS.ErrnoException;
+        // If the file doesn't exist, we don't care
+        if (error.code !== 'ENOENT') {
+          throw e;
+        }
+      }
     },
   };
 }
@@ -51,7 +59,15 @@ export function localFileAssetsAPI(storageConfig: StorageConfig & { kind: 'local
       }
     },
     async delete(filename) {
-      await fs.unlink(path.join(storageConfig.storagePath, filename));
+      try {
+        await fs.unlink(path.join(storageConfig.storagePath, filename));
+      } catch (e) {
+        const error = e as NodeJS.ErrnoException;
+        // If the file doesn't exist, we don't care
+        if (error.code !== 'ENOENT') {
+          throw e;
+        }
+      }
     },
   };
 }