Resolve console error on signin (#8234)

keystonejs · Jan 9, 2023 · d074e42 · d074e42 · vercel · Jan 9, 2023
1 parent c3eccb5
commit d074e42
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 3 deletions.
diff --git a/.changeset/gentle-wolves-travel.md b/.changeset/gentle-wolves-travel.md
@@ -0,0 +1,5 @@
+---
+'@keystone-6/core': patch
+---
+
+Export `next/head` for use in auth package
diff --git a/.changeset/twenty-chefs-kick.md b/.changeset/twenty-chefs-kick.md
@@ -0,0 +1,5 @@
+---
+'@keystone-6/auth': patch
+---
+
+Resolve `loading Admin Metadata` and `<head> cannot appear as a child of <div>` errors on signin
diff --git a/packages/auth/src/components/SigninContainer.tsx b/packages/auth/src/components/SigninContainer.tsx
@@ -4,6 +4,7 @@
 import { ReactNode } from 'react';
 
 import { jsx, Box, Center, useTheme } from '@keystone-ui/core';
+import { Head } from '@keystone-6/core/admin-ui/router';
 
 type SigninContainerProps = {
   children: ReactNode;
@@ -14,9 +15,9 @@ export const SigninContainer = ({ children, title }: SigninContainerProps) => {
   const { colors, shadow } = useTheme();
   return (
     <div>
-      <head>
+      <Head>
         <title>{title || 'Keystone'}</title>
-      </head>
+      </Head>
       <Center
         css={{
           minWidth: '100vw',

diff --git a/packages/auth/src/pages/SigninPage.tsx b/packages/auth/src/pages/SigninPage.tsx
@@ -99,7 +99,6 @@ export const SigninPage = ({
               return;
             }
             reinitContext();
-            router.push(redirect);
           }
         }}
       >

diff --git a/packages/core/src/admin-ui/router.tsx b/packages/core/src/admin-ui/router.tsx
@@ -18,3 +18,7 @@ import { AnchorHTMLAttributes } from 'react';
 export type LinkProps = NextLinkProps & AnchorHTMLAttributes<HTMLAnchorElement>;
 
 export const Link = NextLink;
+
+import NextHead from 'next/head';
+
+export const Head = NextHead;
-Original file line number
+Diff line change
@@ Expand Up / @@ -99,7 +99,6 @@ export const SigninPage = ({ @@
                   return;
                 }
                 reinitContext();
-                router.push(redirect);
               }
             }}
           >
@@ Expand Down @@