Fix existingItem in updateManyMutation hooks (#3241)

keystonejs · Jul 8, 2020 · 61cdafe · 61cdafe
1 parent 5ad84cc
commit 61cdafe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.changeset/famous-pumpkins-raise.md b/.changeset/famous-pumpkins-raise.md
@@ -0,0 +1,5 @@
+---
+'@keystonejs/keystone': patch
+---
+
+Fixed a bug where `existingItem` had the wrong value in hooks during an `updateManyMutation`.
diff --git a/packages/keystone/lib/ListTypes/list.js b/packages/keystone/lib/ListTypes/list.js
@@ -10,6 +10,7 @@ const {
   flatten,
   zipObj,
   createLazyDeferred,
+  arrayToObject,
 } = require('@keystonejs/utils');
 const { parseListAccess } = require('@keystonejs/access-control');
 const { logger } = require('@keystonejs/logger');
@@ -833,9 +834,10 @@ module.exports = class List {
     const access = await this.checkListAccess(context, data, operation, extraData);
 
     const existingItems = await this.getAccessControlledItems(ids, access);
+    const existingItemsById = arrayToObject(existingItems, 'id');
 
     const itemsToUpdate = zipObj({
-      existingItem: existingItems,
+      existingItem: ids.map(id => existingItemsById[id]),
       id: ids, // itemId is taken from here in checkFieldAccess
       data: data.map(d => d.data),
     });