Password field fix (#2421)

keystonejs · Feb 24, 2020 · 1910ed3 · 1910ed3
1 parent 92b8fc4
commit 1910ed3
Showing 1 changed file with 19 additions and 21 deletions.
diff --git a/packages/fields/src/types/Password/views/Field.js b/packages/fields/src/types/Password/views/Field.js
@@ -20,10 +20,12 @@ const PasswordField = ({ onChange, autoFocus, field, value: serverValue, errors,
   const [inputConfirm, setInputConfirm] = useState('');
 
   useEffect(() => {
-    onChange({
-      inputPassword,
-      inputConfirm,
-    });
+    if (isEditing) {
+      onChange({
+        inputPassword,
+        inputConfirm,
+      });
+    }
   }, [inputPassword, inputConfirm]);
 
   useEffect(() => {
@@ -40,6 +42,17 @@ const PasswordField = ({ onChange, autoFocus, field, value: serverValue, errors,
     setShowInputValue(!showInputValue);
   };
 
+  const renderErrors = src => {
+    const appearance = src === errors ? 'danger' : 'warning';
+
+    return src.map(({ message, data }) => (
+      <Alert appearance={appearance} key={message}>
+        {message}
+        {data ? ` - ${JSON.stringify(data)}` : null}
+      </Alert>
+    ));
+  };
+
   const value = serverValue || '';
   const htmlID = `ks-input-${field.path}`;
 
@@ -88,23 +101,8 @@ const PasswordField = ({ onChange, autoFocus, field, value: serverValue, errors,
         )}
       </FieldInput>
 
-      {errors.length
-        ? errors.map(({ message, data }) => (
-            <Alert appearance="danger" key={message}>
-              {message}
-              {data ? ` - ${JSON.stringify(data)}` : null}
-            </Alert>
-          ))
-        : null}
-
-      {warnings.length
-        ? warnings.map(({ message, data }) => (
-            <Alert appearance="warning" key={message}>
-              {message}
-              {data ? ` - ${JSON.stringify(data)}` : null}
-            </Alert>
-          ))
-        : null}
+      {renderErrors(errors)}
+      {renderErrors(warnings)}
     </FieldContainer>
   );
 };