Sets a default radix#382
Merged
Merged
Conversation
aquynh
reviewed
Feb 7, 2019
| KEYSTONE_EXPORT | ||
| ks_err ks_option(ks_engine *ks, ks_opt_type type, size_t value) | ||
| { | ||
| ks->MAI->setRadix(10); |
Member
There was a problem hiding this comment.
i think the default radix is 16, not 10?
Member
|
merged, thanks! |
|
hello, When I set the default radix to 10 : You can also verify results with this python code : import keystone
ks10 = keystone.Ks(keystone.KS_ARCH_X86, keystone.KS_MODE_32)
ks10.syntax = keystone.KS_OPT_SYNTAX_NASM
print(' '.join('{:02x}'.format(x) for x in ks10.asm('push 10')[0]))
ks16 = keystone.Ks(keystone.KS_ARCH_X86, keystone.KS_MODE_32)
ks16.syntax = keystone.KS_OPT_SYNTAX_NASM | keystone.KS_OPT_SYNTAX_RADIX16
print(' '.join('{:02x}'.format(x) for x in ks16.asm('push 10')[0])) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10437
Before it gets used in
AsmLexer::LexDigit