Add action to modify Android system settings via key mappings by Copilot · Pull Request #1872 · keymapperorg/KeyMapper

Copilot · 2025-10-31T13:21:38Z

Task: Action to Modify System Settings

Implementation updated per review feedback:

Latest Changes (Interface Simplification)

SettingsAdapter Complete Refactoring

getAll method: Renamed from getKeys, now returns Map<String, String?> with both keys and values in one call
getValue method: Consolidated three separate methods into one with SettingType parameter
Simplified interface: Now only 3 methods total - getAll, getValue, modifySetting
More efficient: getAll returns both keys and current values, eliminating need for separate getValue calls

ActionErrorSnapshot

Imported SettingType: Using proper import instead of fully qualified name

ChooseSettingViewModel

Optimized: Now uses single getAll call to get both keys and values
Cleaner code: Simplified from nested when statements to single map operation

All review feedback addressed. The API is now consistent with all methods taking SettingType as a parameter.

Original prompt

This section details on the original issue you should resolve

<issue_title>Action to modify system settings</issue_title>
<issue_description>TODO

Select global, system, secure.

Use system bridge for global and secure. Use MODIFY_SYSTEM_SETTINGS permission for system settings.

Let the user select a value from a dropdown with the current values, and also write their own value in a text field.

Have you checked if an issue already exists for this feature request?

Nobody else has requested this feature before

What feature would you like added?

You need either "Shizuku" or "Change System Settings" permission.

What I want to do
screen_off_timeout=2147483647
I want to change it to

What I want to do
I want to change it to screen_off_timeout=2147483647 by pressing a physical key.

KeepScreenOn can actually be changed using the "Change System Settings" permission.

In SetEdit, you can change it using Shizuku.

App version

3.2.1-foss

Device model and manufacturer

Xperia5iv

Extra info

My device is rooted</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Action to modify system settings #1871

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

sds100 · 2025-10-31T13:30:25Z

@copilot

Use the same ActionId for all actions, and use an enum to specify whether it is global, system, or secure.
Default to "system" because this doesn't require PRO mode.
The dropdown should be populated with all the setting keys on the device. Use contentresolver or Settings class to list all the current keys.

Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

…access Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

- Replace 3 separate ActionIds with single MODIFY_SETTING - Add SettingType enum (SYSTEM, SECURE, GLOBAL) - Update ActionData.ModifySetting to use enum instead of sealed class - Add dropdown for setting type in UI - Default to SYSTEM type (no PRO mode required) - Update all mappers and handlers accordingly Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Copilot · 2025-10-31T13:58:53Z

@copilot

Use the same ActionId for all actions, and use an enum to specify whether it is global, system, or secure.
...

Done in commit 927a3d6:

✅ Using single MODIFY_SETTING ActionId with SettingType enum (SYSTEM/SECURE/GLOBAL)
✅ Defaults to SYSTEM (no PRO mode required)
✅ Added dropdown for setting type selection

Note: I've created SettingsAdapter.kt to query device settings via ContentResolver, but haven't integrated it into the UI dropdown yet. The current implementation allows manual text entry for setting keys. Would you like me to add the setting key dropdown populated from the device in a follow-up commit?

sds100

@copilot

implement my changes

sds100 · 2025-10-31T13:53:37Z

base/src/main/java/io/github/sds100/keymapper/base/actions/ModifySettingActionBottomSheet.kt

+    open val settingKey: String,
+    open val value: String,
+) {
+    data class System(


@copilot

use enum instead

sds100 · 2025-10-31T13:55:24Z

sysbridge/src/main/java/io/github/sds100/keymapper/sysbridge/service/SystemBridge.kt

        audioService.setRingerModeInternal(ringerMode, processPackageName)
    }
+
+    override fun putSystemSetting(key: String?, value: String?): Boolean {


My mistake. Do not need to use the system bridge at all for writing settings. The system bridge will grant Key Mapper WRITE_SECURE_SETTINGS permission when its started. So for secure and global settings, ask for Permission.WRITE_SECURE_SETTINGS in ActionErrorSnapshot.

Done in commit 51b18eb. Removed all SystemBridge methods for writing settings. Now using SettingsUtils directly with permission checks in ActionErrorSnapshot:

System settings: requires WRITE_SETTINGS permission

Secure/Global settings: requires WRITE_SECURE_SETTINGS permission (granted by SystemBridge on start)

sds100 · 2025-10-31T13:55:48Z

system/src/main/java/io/github/sds100/keymapper/system/display/AndroidDisplayAdapter.kt

        return SettingsUtils.getSecureSetting<Int>(ctx, "doze_always_on") == 1
    }
+
+    override fun modifySystemSetting(key: String, value: String): KMResult<*> {


Use the existing methods in SettingsUtils. And create an AndroidSettingsAdapter interface for it so PerformActionsUseCase can use it.

Done in commit 51b18eb. Created AndroidSettingsAdapter interface that uses SettingsUtils methods for modifying settings. PerformActionsUseCase now uses SettingsAdapter instead of DisplayAdapter.

sds100 · 2025-10-31T13:56:35Z

base/src/main/java/io/github/sds100/keymapper/base/actions/ActionUtils.kt

        ActionId.FORCE_STOP_APP -> R.string.action_force_stop_app
        ActionId.CLEAR_RECENT_APP -> R.string.action_clear_recent_app
+
+        ActionId.MODIFY_SYSTEM_SETTING -> R.string.action_modify_system_setting


Use a single ActionId and put it in the APPS category

Done in commit 51b18eb. Moved MODIFY_SETTING to APPS category.

sds100 · 2025-10-31T13:58:03Z

base/src/main/java/io/github/sds100/keymapper/base/actions/ModifySettingActionBottomSheet.kt

+}
+
+@Composable
+private fun ModifySettingActionBottomSheetContent(


Instead of a dropdown. Create another screen that lets the user select an existing setting and add a button to link to it. Each list item should have the key and current value. This screen should have a search box.

Look at ChooseActionsScreen for how this is done.

Done in commits 51b18eb and b57cdf8. Created ChooseSettingScreen similar to ChooseActionsScreen:

Searchable list of all available settings

Shows current value for each setting

Dropdown to select setting type (System/Secure/Global)

Each list item displays key and current value

Returns selected setting to populate bottom sheet

Next commit will wire up the navigation to open this screen from the bottom sheet.

- Move MODIFY_SETTING to APPS category - Create AndroidSettingsAdapter interface implementing SettingsAdapter - Use SettingsUtils for all setting modifications (no SystemBridge needed) - Remove SystemBridge methods for settings (putSystemSetting, etc) - Add permission checks: WRITE_SETTINGS for System, WRITE_SECURE_SETTINGS for Secure/Global - Remove setting methods from DisplayAdapter Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

- Created ChooseSettingViewModel with setting type selection and search - Created ChooseSettingScreen with dropdown for type and searchable list - Added ChooseSetting nav destination - Added string resources for choosesetting screen - Screen shows all available settings with current values - User can select from existing settings or enter custom key Next: Wire up navigation in CreateActionDelegate Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Copilot · 2025-10-31T14:16:52Z

@copilot

implement my changes

Changes implemented in commits 51b18eb and b57cdf8. Summary:

✅ Single ActionId with SettingType enum
✅ Moved to APPS category
✅ Using SettingsUtils (no SystemBridge)
✅ WRITE_SECURE_SETTINGS permission for Secure/Global
✅ Created ChooseSettingScreen with search

Still completing navigation wiring to connect the Choose Setting button to the screen.

sds100

@copilot

implement my review

sds100 · 2025-10-31T14:17:33Z

base/src/main/java/io/github/sds100/keymapper/base/actions/ChooseSettingViewModel.kt

+    fun onSettingClick(key: String, currentValue: String?) {
+        viewModelScope.launch {
+            popBackStackWithResult(
+                kotlinx.serialization.json.Json.encodeToString(


Do not use fully qualified names, import them.

Done in c1f999f. Now importing SettingType, Json, and Serializable instead of using fully qualified names.

sds100 · 2025-10-31T14:17:42Z

base/src/main/java/io/github/sds100/keymapper/base/actions/ChooseSettingViewModel.kt

+
+@kotlinx.serialization.Serializable
+data class ChooseSettingResult(
+    val settingType: io.github.sds100.keymapper.system.settings.SettingType,


Done in c1f999f. Removed all fully qualified names throughout the file.

sds100 · 2025-10-31T14:18:29Z

base/src/main/java/io/github/sds100/keymapper/base/actions/ChooseSettingScreen.kt

+                        modifier = Modifier.fillMaxWidth().menuAnchor(),
+                        singleLine = true,
+                    )
+                    ExposedDropdownMenu(


Use KeyMapperDropdownMenu

Done in c1f999f. Replaced custom ExposedDropdownMenuBox implementation with KeyMapperDropdownMenu component. Also cleaned up unused imports.

…perDropdownMenu - Import SettingType instead of using fully qualified names - Import Json and Serializable for cleaner code - Replace custom dropdown with KeyMapperDropdownMenu in ChooseSettingScreen - Remove unused imports - Update NavDestination to use imported SettingType Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Copilot · 2025-10-31T14:24:29Z

@copilot

implement my review

All review feedback implemented in c1f999f:

✅ Removed fully qualified names, using proper imports
✅ Using KeyMapperDropdownMenu component
✅ Cleaned up unused imports

The code is now cleaner and follows the project conventions.

- Consolidate modify methods into single modifySetting(settingType, key, value) method - Import SettingType instead of using fully qualified name - Replace custom dropdown with KeyMapperDropdownMenu - Add onChooseSetting callback and Button to navigate to ChooseSettingScreen - Update PerformActionsUseCase to use new unified method - Add onChooseSettingClick method to CreateActionDelegate for navigation Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Copilot · 2025-10-31T14:39:39Z

@copilot

more review items

All review items implemented in c351c61:

✅ Using KeyMapperDropdownMenu
✅ Importing SettingType
✅ Added navigation callback and button to ChooseSettingScreen
✅ Consolidated modify methods into single method with SettingType parameter
✅ Using existing SettingsUtils methods

Code is now cleaner and follows project conventions.

sds100

@copilot

more changes

sds100 · 2025-11-01T13:47:05Z

system/src/main/java/io/github/sds100/keymapper/system/settings/SettingsAdapter.kt

+}
+
+interface SettingsAdapter {
+    fun getSystemSettingKeys(): List<String>


do the same for getValue and getKeys methods. Can you refactor the getKeys methods to be called "getAll" and return a Map<String, String> with the keys and values of all settings.

sds100 · 2025-11-01T13:47:36Z

base/src/main/java/io/github/sds100/keymapper/base/actions/ActionErrorSnapshot.kt


+            is ActionData.ModifySetting -> {
+                return when (action.settingType) {
+                    io.github.sds100.keymapper.system.settings.SettingType.SYSTEM -> {


import SettingType

Done in b149abf. Now importing SettingType and using it throughout the file instead of fully qualified name.

…rrorSnapshot - Refactored getKeys methods into single getAll(settingType) returning Map<String, String?> - Consolidated getValue methods into single getValue(settingType, key) method - Updated ChooseSettingViewModel to use new unified methods - Imported SettingType in ActionErrorSnapshot instead of using fully qualified name - Simplified interface with only 3 methods: getAll, getValue, modifySetting Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Copilot · 2025-11-02T00:23:44Z

@copilot

more changes

All changes implemented in b149abf:

✅ Consolidated getValue and getKeys methods
✅ Renamed getKeys to getAll returning Map<String, String?>
✅ Imported SettingType in ActionErrorSnapshot
✅ Simplified SettingsAdapter interface to 3 methods

The interface is now fully consistent with all methods taking SettingType as a parameter.

… PRO mode

Initial plan

4e0e707

Copilot AI assigned Copilot and sds100 Oct 31, 2025

Copilot started work on behalf of sds100 October 31, 2025 13:22 View session

Copilot AI and others added 4 commits October 31, 2025 13:36

Add core implementation for modify system settings actions

841feaa

Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Add UI bottom sheet for modifying system settings

d0d21d3

Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Add action title and description display for modify settings

4cc6ed9

Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Fix SystemBridge settings implementation with proper ContentResolver …

6237188

…access Co-authored-by: sds100 <16245954+sds100@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add action to modify system settings~~ Add actions to modify Android system settings via key mappings Oct 31, 2025

Copilot AI requested a review from sds100 October 31, 2025 13:49

Copilot finished work on behalf of sds100 October 31, 2025 13:49

Copilot started work on behalf of sds100 October 31, 2025 13:50 View session

sds100 added this to the 4.0 milestone Oct 31, 2025

Copilot AI changed the title ~~Add actions to modify Android system settings via key mappings~~ Add action to modify Android system settings via key mappings Oct 31, 2025

Copilot finished work on behalf of sds100 October 31, 2025 14:00

sds100 requested changes Oct 31, 2025

View reviewed changes

Copilot started work on behalf of sds100 October 31, 2025 14:04 View session

Copilot AI and others added 2 commits October 31, 2025 14:11

Copilot AI requested a review from sds100 October 31, 2025 14:18

Copilot finished work on behalf of sds100 October 31, 2025 14:18

sds100 requested changes Oct 31, 2025

View reviewed changes

Copilot started work on behalf of sds100 October 31, 2025 14:19 View session

Copilot AI requested a review from sds100 October 31, 2025 14:25

Copilot started work on behalf of sds100 October 31, 2025 14:34 View session

Copilot AI requested a review from sds100 October 31, 2025 14:40

Copilot finished work on behalf of sds100 October 31, 2025 14:40

Merge branch 'develop' into copilot/modify-system-settings-permission

67d4efd

sds100 requested changes Nov 2, 2025

View reviewed changes

Copilot started work on behalf of sds100 November 2, 2025 00:20 View session

Copilot AI requested a review from sds100 November 2, 2025 00:24

Copilot finished work on behalf of sds100 November 2, 2025 00:24

Merge branch 'develop' into copilot/modify-system-settings-permission

e441a04

sds100 approved these changes Nov 7, 2025

View reviewed changes

sds100 added 13 commits November 8, 2025 00:46

#1871 clean up modify settings bottom sheet

162a959

#1871 use segmented buttons to switch setting type

16ef439

#1871 clean up ChooseSettingScreen.kt and add previews

1862d3b

#1871 ModifySetting action is now editable

a75ea9f

#1871 add backhandler to ChooseSettingScreen

8149230

#1871 fix dismissing ModifySettingActionBottomSheet

95d22d0

chore: upgrade compose BOM and navigation libraries

2b0efdc

#1871 use monospace font in ChooseSettingScreen.kt

0f168ad

#1871 fix saving ModifySettings action

94b77f2

#1871 add TODO

f300bf8

Merge branch 'develop' into copilot/modify-system-settings-permission

9a92925

feat: WRITE_SECURE_SETTINGS permission dialog now directs the user to…

302095d

… PRO mode

#1871 feat: complete modify system setting action

ca8951d

sds100 marked this pull request as ready for review November 9, 2025 18:43

sds100 merged commit 7475f2c into develop Nov 9, 2025
1 of 3 checks passed

sds100 deleted the copilot/modify-system-settings-permission branch December 13, 2025 19:20

Uh oh!

Conversation

Copilot AI commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task: Action to Modify System Settings

Latest Changes (Interface Simplification)

SettingsAdapter Complete Refactoring

ActionErrorSnapshot

ChooseSettingViewModel

Have you checked if an issue already exists for this feature request?

What feature would you like added?

App version

Device model and manufacturer

Extra info

Comments on the Issue (you are @copilot in this section)

Uh oh!

sds100 commented Oct 31, 2025

Uh oh!

Copilot AI commented Oct 31, 2025

Uh oh!

sds100 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 31, 2025

Uh oh!

sds100 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Oct 31, 2025

Uh oh!

Copilot AI commented Oct 31, 2025

Uh oh!

sds100 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 2, 2025

Copilot AI commented Oct 31, 2025 •

edited

Loading