refactor(web): matched gesture-component abstraction 🐵 #9525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
mcdurdin
approved these changes
Sep 2, 2023
common/web/gesture-recognizer/src/engine/headless/gestures/matchers/gestureMatcher.ts
Show resolved
Hide resolved
common/web/gesture-recognizer/src/engine/headless/gestures/matchers/gestureMatcher.ts
Outdated
Show resolved
Hide resolved
jahorton
commented
Sep 27, 2023
common/web/gesture-recognizer/src/engine/headless/gestures/matchers/gestureMatcher.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+15
to
+16
| * host apps when it was in an embedded state. While that pattern has been dropped, | ||
| * the abstraction gained from reaching compatibility with it is useful. Either way, |
There was a problem hiding this comment.
In particular, I've found that the process resulted in much clearer field names and helped to clarify some of the connections among all the moving pieces.
Also, I'd based a lot of things off the abstraction before #9591 landed, it's pretty well integrated into the code that follows... and it's an interface, meaning it compiles completely out when converted to JS. No filesize contribution, save maybe due to change in the length of names of the fields.
Base automatically changed from
feat/web/gesture-selection
to
feature-gestures
September 27, 2023 01:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's primary changes seek to facilitate app/webview's delegated longpress behavior as used by our Android app.
While working on #9455, I noticed that a little abstraction would be needed in order to be compatible with such longpresses. In such cases, the "subkey menu" aspect of a longpress would not have any corresponding
GestureMatcherinstance... and up until now, I've written further implementation assuming that one would exist.Long story short, this led to the
PredecessorMatchinterface defined herein; it's reasonable to construct a version of this on behalf of a delegated longpress/subkey menu. Doing so allows us to treat the result of that delegation similarly to a gesture component recognized by the gesture-engine itself, mitigating the need for further code divergence in support of Android-app longpresses.While I was at it, I figured that one of the Matcher properties could use a better, clearer name... so I made that change.
Both sets of changes forced a bit of unit-test maintenance, but it was fortunately pretty small-scale - and it even makes one aspect of certain test-setups clearer, which was a nice bonus.
@keymanapp-test-bot skip