fix(android/engine): Handle parsing empty JSONArray as JSONObject#7611
Merged
darcywong00 merged 2 commits intobetafrom Nov 3, 2022
Merged
fix(android/engine): Handle parsing empty JSONArray as JSONObject#7611darcywong00 merged 2 commits intobetafrom
darcywong00 merged 2 commits intobetafrom
Conversation
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
approved these changes
Nov 3, 2022
android/KMEA/app/src/main/java/com/tavultesoft/kmea/JSONParser.java
Outdated
Show resolved
Hide resolved
….java Co-authored-by: Marc Durdin <marc@durdin.net>
Collaborator
|
Changes in this pull request will be available for download in Keyman version 16.0.96-beta |
|
Sentry issue: KEYMAN-ANDROID-PB |
Member
I think I'd like to verify the root cause of this on api.keyman.com as well -- and make sure that there are not circumstances where this is happening, wrongly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7564
I'm not sure the circumstances, but from the Sentry logs it appears there's times the Cloud catalog queries return
[]and the Keyman Engine JSON parsing code throws an exception treating it as a JSONObject.This updates the JSON parser to treat
[]as an empty JSON Object.@keymanapp-test-bot skip