Skip to content

fix(developer): support CLDR sample keyboards 🙀#7479

Merged
srl295 merged 2 commits intochore/resources/7411-ldmlupdate-epic-ldmlfrom
fix/developer/7411-support-cldr-epic-ldml
Oct 19, 2022
Merged

fix(developer): support CLDR sample keyboards 🙀#7479
srl295 merged 2 commits intochore/resources/7411-ldmlupdate-epic-ldmlfrom
fix/developer/7411-support-cldr-epic-ldml

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Oct 18, 2022

With this, kmc is at least able to load mt.xml and fr-t-k0-azerty.xml but runs into issues from #7402 and also lack of import support.

for #7411

includes an update to CLDR data from PR unicode-org/cldr#2469

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Oct 18, 2022

CLDR data update from unicode-org/cldr#2469

- displays is not an array

#7411
With this change, fr-t-k0-azerty.xml and mt.xml can load without any
ERROR 300007: The source file has an invalid structure errors.

Other errs show up, but it is progress.

Fixes #7411
@srl295 srl295 force-pushed the fix/developer/7411-support-cldr-epic-ldml branch from 1eb77d0 to 8ffba3f Compare October 18, 2022 17:54
@srl295 srl295 marked this pull request as ready for review October 18, 2022 17:54
@srl295 srl295 added this to the A16S13 milestone Oct 18, 2022
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now this has the updated ldmlKeyboard.dtd for displays? 😁 that I suggested in #7477.

@srl295 srl295 merged commit 64af829 into chore/resources/7411-ldmlupdate-epic-ldml Oct 19, 2022
@srl295 srl295 deleted the fix/developer/7411-support-cldr-epic-ldml branch October 19, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants