change(web): drops hacky approach to focus-based-event unit-tests 📴#7367
Closed
change(web): drops hacky approach to focus-based-event unit-tests 📴#7367
Conversation
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
bot
removed
the
user-test-missing
Base automatically changed from
fix/common/web/mock-deadkey-handling
to
master
September 29, 2022 03:37
Contributor
Author
|
I'm closing this due to a number of small factors:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm spinning this off from #7343, as there's plenty enough just to review within the one file... and, fortunately, the changes are pretty orthogonal. Well, outside of the unit test issue that arises in #7343 when this PR's changes aren't present.
@keymanapp-test-bot skip