chore(web): drops alignInputs, hideInputs 📴#7360
Conversation
keymanapp-test-bot
bot
added
the
user-test-missing
User Test ResultsTest specification and instructions User tests are not required |
jahorton
force-pushed
the
change/web/drop-alignInputs
branch
from
1c28631 to
e579530
Compare
jahorton
force-pushed
the
change/web/drop-touch-aliases
branch
2 times, most recently
from
5825921 to
897d3d7
Compare
jahorton
force-pushed
the
change/web/drop-alignInputs
branch
from
e579530 to
d1887a5
Compare
keymanapp-test-bot
bot
removed
the
user-test-missing
mcdurdin
left a comment
mcdurdin
left a comment
There was a problem hiding this comment.
Looking good. I think we can go a couple of steps further, removing more util code, which maketh me happy!
web/source/kmwbase.ts
Outdated
| // Legacy API function for touch-alias issue workarounds | ||
| // Touch-aliases have been eliminated, though. | ||
| ['alignInputs'](eleList?: HTMLElement[]){} |
There was a problem hiding this comment.
Why are we keeping this here? Is it just because it was a published and documented API?
In this situation, we then need a PR against the documentation to mark it as deprecated, so it can be removed in a future version.
There was a problem hiding this comment.
|
After a bit more investigation into any possible extra avenues for cleanup, I've documented #7387. It's not 100% straightforward, so it should probably be left out of this PR. |
…web/drop-alignInputs
|
Changes in this pull request will be available for download in Keyman version 16.0.82-alpha |
3 participants
A follow-up to #7343.
I could've included it as part of that one, but these changes were easy enough to isolate and may be worth some discussion in isolation, given the old
waitForFontsmethod. It is my understanding thatwaitForFontsexisted to prevent a "flash of unstyled content" effect on touch-alias elements that would otherwise result from asynchronous font loads.@keymanapp-test-bot skip