fix(core): normalization segment should end on NFC boundary, not NFD #15506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keymanapp-test-bot
bot
added
has-user-test
user-test-missing
User Test ResultsTest specification and instructions
|
keymanapp-test-bot
bot
added
user-test-required
mcdurdin
requested review from
ermshiperete and
srl295
and removed request for
srl295
mcdurdin
force-pushed
the
fix/core/15491-15505-bengali-normalization-and-tests
branch
from
f2cde17 to
82083f8
Compare
When normalizing, we need to stop processing on an NFC boundary, not an NFD boundary, to support normalizations such as in Bengali, where appending `U+09D7` to a context of `U+0995 U+09C7` should result in `U+0995 U+09CC`. The specification is unclear on this; see https://unicode-org.atlassian.net/browse/CLDR-19218 This also updates the ldml keyboard unit test suite to support running in full NFC mode (used in all Engine implementations) as well retaining the NFD mode (now only used by the debugger). Side note: the Bengali normalization failure case was picked up by the improvements to the unit test suite, proving once again that good tests are so valuable. Fixes: #15491 Fixes: #15505 Follows: #15488 Relates-to: CLDR-19218
mcdurdin
force-pushed
the
fix/core/15491-15505-bengali-normalization-and-tests
branch
from
82083f8 to
766c699
Compare
darcywong00
reviewed
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Does this write NFC now?
Member
Author
There was a problem hiding this comment.
yes, missed that, good catch!
ermshiperete
approved these changes
Jan 28, 2026
core/tests/unit/ldml/ldml.cpp
Outdated
Comment on lines
745
to
746
| return EXIT_FAILURE; | ||
| return rc; |
Contributor
There was a problem hiding this comment.
Suggested change
| return EXIT_FAILURE; | |
| return rc; | |
| return EXIT_FAILURE; |
|
|
||
| void print_context(std::u16string &text_store, km_core_state *&test_state, std::vector<km_core_context_item> &test_context); | ||
|
|
||
| bool g_beep_found = false; |
Contributor
There was a problem hiding this comment.
It might be good to set g_beep_found = false; at the beginning of run_test to make things more robust.
Contributor
@mcdurdin, could you confirm that U+09CC is suppose to be U+09CB? |
Member
Author
The output is supposed to be U+09CC. Apologies, the keystrokes should be deA. My mistake. I will update the test spec too. |
Co-authored-by: Darcy Wong <darcy_wong@sil.org> Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
This was
linked to
issues
Feb 1, 2026
Contributor
Test Prerequisites
Test ResultsGROUP_WINDOWS:Test Specs:
GROUP_MAC:Test Specs:
|
ermshiperete
approved these changes
Feb 2, 2026
Member
Author
Test ResultsTested on Ubuntu 24.04 X11 with Gnome Text Editor. GROUP_LINUX: Test on Linux
|
keymanapp-test-bot
bot
removed
the
user-test-required
mcdurdin
added a commit
that referenced
this pull request
Feb 3, 2026
When normalizing, we need to stop processing on an NFC boundary, not an NFD boundary, to support normalizations such as in Bengali, where appending `U+09D7` to a context of `U+0995 U+09C7` should result in `U+0995 U+09CC`. The specification is unclear on this; see https://unicode-org.atlassian.net/browse/CLDR-19218 This also updates the ldml keyboard unit test suite to support running in full NFC mode (used in all Engine implementations) as well retaining the NFD mode (now only used by the debugger). Side note: the Bengali normalization failure case was picked up by the improvements to the unit test suite, proving once again that good tests are so valuable. Fixes: #15491 Fixes: #15505 Follows: #15488 Cherry-pick-of: #15506 Relates-to: CLDR-19218
mcdurdin
deleted the
fix/core/15491-15505-bengali-normalization-and-tests
branch
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.198-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When normalizing, we need to stop processing on an NFC boundary, not an NFD boundary, to support normalizations such as in Bengali, where appending
U+09D7to a context ofU+0995 U+09C7should result inU+0995 U+09CC.The specification is unclear on this; see https://unicode-org.atlassian.net/browse/CLDR-19218
This also updates the ldml keyboard unit test suite to support running in full NFC mode (used in all Engine implementations) as well retaining the NFD mode (now only used by the debugger).
Side note: the Bengali normalization failure case was picked up by the improvements to the unit test suite, proving once again that good tests are so valuable.
Fixes: #15491
Fixes: #15505
Follows: #15488
Relates-to: CLDR-19218
Build-bot: release:windows,linux,mac
User Testing
Tests should be run with the following keyboard: bn_ldml.zip
GROUP_WINDOWS: Test on Windows
GROUP_MAC: Test on macOS
GROUP_LINUX: Test on Linux
TEST_NORMALIZATION: Type deA. Copy the output and paste it into a character viewer. The output should be
U+09A6 U+09CC.