Skip to content

feat(windows): add ARM support to firstvoices wxs 🦾#15268

Merged
rc-swag merged 2 commits intoepic/win-armfrom
feat/windows/15260/update-firstvoices-wxs
Dec 16, 2025
Merged

feat(windows): add ARM support to firstvoices wxs 🦾#15268
rc-swag merged 2 commits intoepic/win-armfrom
feat/windows/15260/update-firstvoices-wxs

Conversation

@rc-swag
Copy link
Contributor

@rc-swag rc-swag commented Dec 3, 2025

Fixes: #15260

--- Removed --- User Testing

TEST_INSTALLATION_BASIC

Installation verify FirstVoices installs and do a basic check to see it has installed correctly.
For example

  1. Open Configuration - no issues
  2. Open notepad and use a keyboard

On existing Windows x86-x64 archeticture
Basic Test
On any Windows 10 or 11 32bit or the 64bit

TEST_MULTIPLE_EDITORS_NON_COMPLIANT

In install on a Windows 11 on Arm machine
Use the attached 32bit, 64 bit, and Arm editor.These editor is non-compliant
Select a FirstVoices Keyboard
Type a sequence that should work
Do this for each architecture version ot the text editor.
Continue to TEST_MULTIPLE_EDITORS_COMPLIANT

TEST_MULTIPLE_EDITORS_COMPLIANT

If you haven't already install Windows 11 on Arm machine
Now open compliant apps to check on Windows 11 this can be Notepad for Windows 11

@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 3, 2025

@keymanapp-test-bot keymanapp-test-bot bot changed the title feat(windows): update firstvoices wxs feat(windows): update firstvoices wxs 🦾 Dec 3, 2025
@keymanapp-test-bot keymanapp-test-bot bot added this to the A19S17 milestone Dec 3, 2025
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Dec 3, 2025
@rc-swag rc-swag requested a review from mcdurdin December 3, 2025 01:45
@rc-swag rc-swag self-assigned this Dec 3, 2025
Copy link
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failed:

02:46:26       C:\BuildAgent\work\7ac43416c45637e9\keyman\oem\firstvoices\windows\src\inst\firstvoices.wxs(187) : error LGHT0094 : Unresolved reference to symbol 'Property:WIX_NATIVE_MACHINE' in section 'Product:*'.
02:46:26       [oem/firstvoices/windows/src/inst] ## publish failed

@mcdurdin mcdurdin changed the title feat(windows): update firstvoices wxs 🦾 feat(windows): add ARM support to firstvoices wxs 🦾 Dec 3, 2025
@github-actions github-actions bot added windows/ and removed windows/ labels Dec 4, 2025
@rc-swag
Copy link
Contributor Author

rc-swag commented Dec 4, 2025

Build failed:

02:46:26       C:\BuildAgent\work\7ac43416c45637e9\keyman\oem\firstvoices\windows\src\inst\firstvoices.wxs(187) : error LGHT0094 : Unresolved reference to symbol 'Property:WIX_NATIVE_MACHINE' in section 'Product:*'.
02:46:26       [oem/firstvoices/windows/src/inst] ## publish failed

my bad left out the -ext WixUtilExtension flag on the light command in build.sh

@keyman-server keyman-server modified the milestones: A19S17, A19S18 Dec 6, 2025
@sze2st
Copy link
Contributor

sze2st commented Dec 10, 2025

Test Results

Testing this PR in the "Keyman-19.0.164-alpha-test-15268" build on Windows 11 arm and focusing on the part installation keyman/downloading keyboard.

  • TEST_INSTALLATION_BASIC (failed):
  1. Installation on Windows 11 arm fails if there is already another version (e.g. Keyman-19.0.164-alpha-test-15181 or Keyman-19.0.173-alpha) being installed. The already installed version is overwritten either when using the Install options and explicitely selecting the desired version. Moreover if there is already a Keyman Configuration open with e.g. Keyman-19.0.164-alpha-test-15181 a try to install Keyman-19.0.164-alpha-test-15268 causes the Keyman Configuration window can no longer be closed other than by TaskManager. i.e. switching between Keyboard Layouts, Options etc. is still possible but Exit button or the cross X does not close the window.
  2. Installation from scratch (without any Keyman version yet installed) - no issue
  3. usingInstallation was done with user having administration rights as well as with user without administration rights (where latter requires switch to administration user during installation) - no issues
  4. Installation firstvoices-19.0.164-alpha-test-15268 - no issues
  5. Enabling EuroLatin en-DE from FirstVoices and using it with newly started Notepad:
    ^ + e --> ê
    ` + e --> è
    ´ + e --> ´e fails (in later tests for some unknown reason the sequence lead to expected é
  6. Closing Notepad and Download and install IPA and opening Notepad and selecting IPA -->
grafik then any further typing is prevented in Notepad which needs to be closed 6. Opening Notepad again and selecting IPA: s + = --> s= (failed)
  • TEST_MULTIPLE_EDITORS_NON_COMPLIANT (passed):
  1. editor32 using FirstVoice EuroLatin en-DE: - ê, é and è as expected --> no issues
  2. editor32 using FirstVoice EuroLatin en-US: - neither ê, é nor è as expected --> failed
  3. editor32 using IPA: neither f= nor s= as expected --> failed
  4. editor64 using FirstVoice EuroLatin en-DE: - ê, é and è as expected --> no issues
  5. editor64 using FirstVoice EuroLatin en-US: - neither ê, é nor è as expected --> failed
  6. editor64 using IPA: neither f= nor s= as expected --> failed
  7. editorarm64 using FirstVoice EuroLatin en-DE: - ê, é and è as expected --> no issues
  8. editorarm64 using FirstVoice EuroLatin en-US: - neither ê, é nor è as expected --> failed
  9. editorarm64 using IPA: neither f= nor s= as expected --> failed
    Remark: with FirstVoice EuroLatin en-DE typing ^ or ´ or ` is not displayed and will only be contracted with following e.
  • TEST_MULTIPLE_EDITORS_COMPLIANT (failed):
    With Notepad and editpad (with Firefox) same behaviour as with non-compliant editors. However using FirstVoice EuroLatin en-DE and temporarily switching to another app before typing e leads to ê, é and è respectively.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 10, 2025
Base automatically changed from feat/windows/64x-pure-forwarder-wix-3 to epic/win-arm December 11, 2025 00:31
@rc-swag
Copy link
Contributor Author

rc-swag commented Dec 16, 2025

This PR has uncovered a larger problem with the Firstvoices Windows installer on the stable and master branch and will be addressed with this issue #15359.

This PR can still be merged as the code change will still be needed.

@rc-swag
Copy link
Contributor Author

rc-swag commented Dec 16, 2025

Due to the fact the issues are present on the main branch we will do a test skip for this small code change.
Test-bot: skip

@rc-swag rc-swag merged commit 15feec8 into epic/win-arm Dec 16, 2025
8 checks passed
@rc-swag rc-swag deleted the feat/windows/15260/update-firstvoices-wxs branch December 16, 2025 09:02
@github-project-automation github-project-automation bot moved this from Todo to Done in Keyman Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants