feat(windows): add ARM support to firstvoices wxs 🦾#15268
Merged
rc-swag merged 2 commits intoepic/win-armfrom Dec 16, 2025
Merged
feat(windows): add ARM support to firstvoices wxs 🦾#15268rc-swag merged 2 commits intoepic/win-armfrom
rc-swag merged 2 commits intoepic/win-armfrom
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
mcdurdin
requested changes
Dec 3, 2025
Member
mcdurdin
left a comment
There was a problem hiding this comment.
Build failed:
02:46:26 C:\BuildAgent\work\7ac43416c45637e9\keyman\oem\firstvoices\windows\src\inst\firstvoices.wxs(187) : error LGHT0094 : Unresolved reference to symbol 'Property:WIX_NATIVE_MACHINE' in section 'Product:*'.
02:46:26 [oem/firstvoices/windows/src/inst] ## publish failed
Contributor
Author
my bad left out the -ext WixUtilExtension flag on the light command in build.sh |
mcdurdin
approved these changes
Dec 4, 2025
Contributor
Test ResultsTesting this PR in the "Keyman-19.0.164-alpha-test-15268" build on Windows 11 arm and focusing on the part installation keyman/downloading keyboard.
|
Base automatically changed from
feat/windows/64x-pure-forwarder-wix-3
to
epic/win-arm
December 11, 2025 00:31
Contributor
Author
|
This PR has uncovered a larger problem with the Firstvoices Windows installer on the stable and master branch and will be addressed with this issue #15359. This PR can still be merged as the code change will still be needed. |
Contributor
Author
|
Due to the fact the issues are present on the main branch we will do a test skip for this small code change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15260
--- Removed --- User Testing
TEST_INSTALLATION_BASIC
Installation verify FirstVoices installs and do a basic check to see it has installed correctly.
For example
On existing Windows x86-x64 archeticture
Basic Test
On any Windows 10 or 11 32bit or the 64bit
TEST_MULTIPLE_EDITORS_NON_COMPLIANT
In install on a Windows 11 on Arm machine
Use the attached 32bit, 64 bit, and Arm editor.These editor is non-compliant
Select a FirstVoices Keyboard
Type a sequence that should work
Do this for each architecture version ot the text editor.
Continue to
TEST_MULTIPLE_EDITORS_COMPLIANTTEST_MULTIPLE_EDITORS_COMPLIANT
If you haven't already install Windows 11 on Arm machine
Now open compliant apps to check on Windows 11 this can be Notepad for Windows 11