Skip to content

[api.keyman.com] Lexical model schema drafts#1

Merged
mcdurdin merged 7 commits intomasterfrom
lexical-model-schemas
Feb 14, 2019
Merged

[api.keyman.com] Lexical model schema drafts#1
mcdurdin merged 7 commits intomasterfrom
lexical-model-schemas

Conversation

@mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Feb 8, 2019

No description provided.

@mcdurdin mcdurdin force-pushed the lexical-model-schemas branch from 858f8d8 to 7807ed1 Compare February 8, 2019 01:49
@mcdurdin mcdurdin added enhancement New feature or request api.keyman.com labels Feb 8, 2019
@darcywong00 darcywong00 added this to the P5S4 milestone Feb 11, 2019
darcywong00
darcywong00 previously approved these changes Feb 11, 2019
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin dismissed darcywong00’s stale review February 11, 2019 20:40

Source model_info was broken, needs re-review.

@eddieantonio
Copy link

I'm assuming some of the string patterns in model_info.source.json will be relaxed in the future. Other than that, LGTM!

"version": {
"type": "string"
},
"rtl": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be isRTL to be consistent with #/definitions/ModelInfo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency would be a nice thing to have. Sadly I've chosen to use rtl to be consistent with package.json#/definitions/keyboards/rtl... so at least the fields are relatively consistent within a single file.

@mcdurdin
Copy link
Member Author

I'm assuming some of the string patterns in model_info.source.json will be relaxed in the future.

I'm not sure which string patterns you mean? If you mean the filename patterns, I don't plan to relax them because they are enforcing a structure in the repository and distribution. There's no requirement for models distributed outside our repo/Keyman Cloud distribution model to follow those patterns, but then they don't need a .model_info file either. Hope that makes sense?

Note: I realised I annotated the 11.0 version of the kmp.json metadata file. Will correct to annotating 12.0 version (requires a separate PR to seed the 12.0 docs).

@mcdurdin
Copy link
Member Author

Not merging yet: need to sort out versioning on (all) schema files

@mcdurdin mcdurdin merged commit 61b57f4 into master Feb 14, 2019
@mcdurdin mcdurdin deleted the lexical-model-schemas branch February 14, 2019 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api.keyman.com enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants