config: Refactor AgentConfig Source trait implementation
#856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansasaki
force-pushed
the
refactor_config
branch
from
b1501dd to
529a402
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/packit retest-failed |
1 similar comment
|
/packit retest-failed |
|
/packit retest-failed |
Instead of using explicit dedicated transformations for each option in the configuration structure, use an intermediary JSON structure to implement the collect() method in a more generic way. This makes it easier to add new configuration options and simplifies maintenance. Also, instead of duplicating the AgentConfig structure to receive the options set in the environment variables, use the built-in Environment Source trait implementation with a small change to make it possible to use as a source for a KeylimeConfig structure. Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
ansasaki
force-pushed
the
refactor_config
branch
from
529a402 to
9067f99
Compare
THS-on
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using explicit dedicated transformations for each option in the configuration structure, use an intermediary JSON structure to implement the
collect()method in a more generic way.This makes it easier to add new configuration options and simplifies maintenance.
Also, instead of duplicating the
AgentConfigstructure to receive the options set in the environment variables, use the built-inEnvironmentSourcetrait implementation with a small change to make it possible to use as a source for aKeylimeConfigstructure.