context_info_handler: Do not assume /var/lib/keylime exists #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the tests in the context_info_handler.rs to not assume the /var/lib/keylime exists. In tests, whenever a configuration is necessary, the `config::get_testing_config()` should be called, passing the path to a temporary directory as argument so that it overrides the `keylime_dir` option to not use the default `/var/lib/keylime`. Note that this is only available when the `testing` feature is enabled. This is necessary to avoid the tests to fail when the `/var/lib/keylime` directory is not present, for example in build systems or when the tests are executed before Keylime is installed. Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
sarroutbi
reviewed
Jul 10, 2025
| @@ -101,16 +102,15 @@ mod tests { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| #[cfg(feature = "testing")] | |||
There was a problem hiding this comment.
Why did you remove this "testing" feature label? If I am not wrong, all the TPM related tests are executed with it
There was a problem hiding this comment.
Because it is redundant, the whole tests module is annotated (see the line 78 above), which means it is only compiled when the testing feature is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the tests in the context_info_handler.rs to not assume the
/var/lib/keylimeexists.In tests, whenever a configuration is necessary, the
config::get_testing_config()should be called, passing the path to a temporary directory as argument so that it overrides thekeylime_diroption to not use the default/var/lib/keylime.Note that this is only available when the
testingfeature is enabled.This is necessary to avoid the tests to fail when the
/var/lib/keylimedirectory is not present, for example in build systems or when the tests are executed before Keylime is installed.