Skip to content

Conversation

@Snawoot
Copy link
Collaborator

@Snawoot Snawoot commented Dec 28, 2016

Deeper analysis of libnvidia-encode internals revealed invokation of libnvcuvid functions for purpose of checking number of running encoders.

Current patch circumvents result check of this function inside nvEncOpenEncodeSessionEx function body. Probably, most proper way is to patch function which does immediate check of running encoders, and this patch supposed to do this. This patch works as well as one which patched libnvidia-encode.so, but "fixes" decision in right place.

@keylase keylase self-requested a review June 23, 2018 15:57
@barhom
Copy link

barhom commented Jul 17, 2018

@keylase
Can you please tell us why this is marked as wontfix?
Can you explain how @Snawoot solution is worse than this solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants