keycloak_openid_client remove merge with existing config on import #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not obvious by the error messages why the acceptance tests failed - some help would be greatly appreciated :) |
|
any chance this can get into next release? |
|
Oh dear... |
chrismilson
force-pushed
the
master
branch
3 times, most recently
from
c60f5bd to
90bab85
Compare
Signed-off-by: Chris Milson-Tokunaga <chris.w.milson@gmail.com>
Signed-off-by: Chris Milson-Tokunaga <chris.w.milson@gmail.com>
|
@chrismilson Have you tried running the tests locally? |
|
@sschu I have not been able to do that - I have had trouble setting up the development environment locally I should be able to run tests locally over the weekend though. |
Signed-off-by: Chris Milson-Tokunaga <chris.w.milson@gmail.com>
|
I was able to run tests locally. Had a little difficulty setting up the environment, but I'll put that info in a separate issue. Should be ready for review, now @sschu. Thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007