Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cache for IdentityProviderStorageProvider.getForLogin #32918

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Add cache for IdentityProviderStorageProvider.getForLogin #32918

merged 1 commit into from
Sep 18, 2024

Conversation

sguilhen
Copy link
Contributor

Closes #32573

@sguilhen sguilhen requested review from a team as code owners September 13, 2024 17:35
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Sep 13, 2024
Closed
@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.passwordless.WebAuthnPwdLessPropertyTest#residentKey

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=01a0a971-ab29-4db7-92ec-44e2ec46526c&session_state=cbdbbbd9-18ab-490a-b21e-871d056f560c&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=a2f8ec50-1482-44eb-8462-0ba9a001af54.cbdbbbd9-18ab-490a-b21e-871d056f560c.e71c543f-64b5-4ea3-ad9f-43c87eafe289)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithEmailUserAndRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithEmailUserAndRememberMe(LoginTest.java:740)
...

Report flaky test

@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Sep 13, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 13, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@sguilhen sguilhen requested a review from vramik September 13, 2024 19:44
@sguilhen sguilhen force-pushed the 32573-login-idp-cache branch from f3bab50 to ac7ee94 Compare September 13, 2024 19:46
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 13, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnTransportsTest#usbTransport

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=3e73d7a9-6e23-42e2-8fe1-07f00f4fa17c&session_state=331117c7-6f85-46af-ab85-1752489d4f3f&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=091a1ae2-c6f1-4bfc-8048-8a719568e7ea.331117c7-6f85-46af-ab85-1752489d4f3f.b06052ff-0293-45fa-8015-a0035a0fc569)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyNotRequiredNoRK

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=cce0dd77-40f5-4450-8219-4c9f25e7a94e&session_state=a94d664f-7c89-472a-8d04-33d69eb9bfd7&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=b1efe349-6d2d-401c-842d-06fb215f3900.a94d664f-7c89-472a-8d04-33d69eb9bfd7.39ff780e-400e-4de1-836b-f2aed090ff6c)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

org.keycloak.testsuite.forms.RegisterTest#testRegisterShouldFailBeforeUserCreationWhenUserIsInContext

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Expected ErrorPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=e32eb149-c3dc-40cb-887e-f8ba3ffc0bf8&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.url.HostnameV2Test#testStrictMode

Keycloak CI - Base IT (6)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

org.keycloak.testsuite.url.HostnameV2Test#testInvalidAdminUrl

Keycloak CI - Base IT (6)

jakarta.ws.rs.NotFoundException: HTTP 404 Not Found
	at org.jboss.resteasy.client.jaxrs.internal.ClientInvocation.handleErrorStatus(ClientInvocation.java:242)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.extractors.DefaultEntityExtractorFactory$3.extractEntity(DefaultEntityExtractorFactory.java:41)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invokeSync(ClientInvoker.java:136)
	at org.jboss.resteasy.client.jaxrs.internal.proxy.ClientInvoker.invoke(ClientInvoker.java:103)
...

Report flaky test

vramik
vramik approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@vramik vramik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sguilhen

@sguilhen sguilhen force-pushed the 32573-login-idp-cache branch from ac7ee94 to ebf14e3 Compare September 16, 2024 12:21
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request Sep 16, 2024
Closed
keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 16, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyNotRequiredNoRK

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected LoginPage but was AUTH_RESPONSE (https://localhost:8543/auth/realms/master/app/auth?state=f3744a82-c8ee-4891-bcba-5872b501d7f2&session_state=6e61604c-a90e-4d80-9d07-27791a3c280e&iss=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest&code=4e2842ab-0068-4761-b1ce-281811942aa9.6e61604c-a90e-4d80-9d07-27791a3c280e.f437bc56-c38d-4456-b026-2125aec67171)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at org.keycloak.testsuite.pages.LoginPage.open(LoginPage.java:262)
...

Report flaky test

@sguilhen @ssilvert
Add cache for IdentityProviderStorageProvider.getForLogin
e944e2a 
Closes keycloak#32573

Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
@ssilvert ssilvert force-pushed the 32573-login-idp-cache branch from ebf14e3 to e944e2a Compare September 16, 2024 18:34
This was referenced Sep 16, 2024
Closed
Closed
This was referenced Sep 16, 2024
Closed
Closed
@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.WebAuthnPropertyTest#requiredActionRegistration

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=96f4e722-3c86-4779-bb44-26e8cadb7b56&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.forms.LevelOfAssuranceFlowTest#testWithOTPAndRecoveryCodesAtLevel2

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError: Event expected
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertNotNull(Assert.java:713)
	at org.keycloak.testsuite.AssertEvents.poll(AssertEvents.java:91)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot bot reviewed Sep 16, 2024
View reviewed changes
Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

mhajas
mhajas approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the review from @vramik

@mhajas mhajas merged commit 3e59772 into keycloak:main Sep 18, 2024
75 checks passed
keshavprashantdeshpande pushed a commit to keshavprashantdeshpande/keycloak that referenced this pull request Sep 20, 2024
@sguilhen @keshavprashantdeshpande
Add cache for IdentityProviderStorageProvider.getForLogin (keycloak#3…
7a7df51 
…2918)

Closes keycloak#32573

Signed-off-by: Stefan Guilhen <sguilhen@redhat.com>
@sguilhen sguilhen deleted the 32573-login-idp-cache branch October 25, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments

@mhajas mhajas mhajas approved these changes

@vramik vramik vramik approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add caching when querying brokers by fetch mode and organization id
3 participants
@sguilhen @vramik @mhajas