KEYCLOAK-3491 Revise Scripting Support #3189
Conversation
thomasdarimont
force-pushed
the
issue/KEYCLOAK-3491-revise-scripting-support
branch
7 times, most recently
from
6c94b84 to
fc7d8f3
Compare
| @@ -33,7 +33,7 @@ | |||
| </div> | |||
|
|
|||
| <div class="col-md-6" data-ng-show="option.type == 'Script'"> | |||
| <div ng-model="config[option.name][0]" placeholder="Enter your script..." ui-ace="{ useWrapMode: true, showGutter: true, theme:'github', mode: 'javascript'}"> | |||
| <div ng-model="config[option.name]" placeholder="Enter your script..." ui-ace="{ useWrapMode: true, showGutter: true, theme:'github', mode: 'javascript'}"> | |||
There was a problem hiding this comment.
How can I get the default value of the option shown here?
the default value contains an authenticator template for a quickstart.
There was a problem hiding this comment.
Not sure - it's probably burried in server info somewhere
There was a problem hiding this comment.
I found it ... i needed to propagate the default values of the configuration properties within the AuthenticationConfigCreateCtrl in realm.js
| @@ -0,0 +1,26 @@ | |||
| // import enum for error lookup | |||
There was a problem hiding this comment.
This is the default authenticator template that should be shown in the code editor for a quick start.
|
Will update the docks tomorrow - but I think the PR is now ready for review. |
thomasdarimont
force-pushed
the
issue/KEYCLOAK-3491-revise-scripting-support
branch
2 times, most recently
from
8838991 to
4d2a8e9
Compare
|
FYI Just rebased the PR on current master. |
thomasdarimont
force-pushed
the
issue/KEYCLOAK-3491-revise-scripting-support
branch
from
4d2a8e9 to
f834180
Compare
|
Did you add docs? |
thomasdarimont
force-pushed
the
issue/KEYCLOAK-3491-revise-scripting-support
branch
from
f834180 to
17e6998
Compare
|
Yes, but I wanted to wait for feedback first - here they are: |
Refactored the scripting infrastructure and added documentation. Added tests and an authenticator template in JavaScript for a quickstart. Increased height of ace code editor to 600px to avoid scrolling.
thomasdarimont
force-pushed
the
issue/KEYCLOAK-3491-revise-scripting-support
branch
from
17e6998 to
8e11338
Compare
|
... added some missing license headers. |
Refactored the scripting infrastructure and added documentation.
Added tests and an authenticator template in JavaScript for a quickstart.