-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing ldap connection should not process or bind the credentials #31081
Conversation
Closes keycloak#30821 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pedroigor! LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on previous reviews
…eycloak#31081) Closes keycloak#30821 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
…eycloak#31081) Closes keycloak#30821 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
…eycloak#31081) Closes keycloak#30821 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
I tested this by running from quay.io/keycloak/keycloak:nightly today (July 9th, 2024). It still failed. This now seems to be happening consistently - I cannot save and use an AD federation on the nightly build because the bindCredentials is always reset (since it is masked I don't know what it is set to). I am attaching the new realm, and the trace log (though there is nothing in the log when the errors occur) One note - this only happens when using ACTIVE DIRECTORY as the vendor. Using OTHER it works as expected. (I don't have Red Hat, Tivoli or Novell to test against) |
Argggh! It's because you are using email format for the bind DN and not a proper DN. If you use a Dn instead of the email of the admin proxy user in ldap it will work. I'm going to file a new issue. It's incredible the mess I did with such a simple change. Sorry. |
Hmmm - when I was given the credentials is was the email address and password which worked before. |
I created #31196 for the samaccountname@domain format. |
Thanks - but I think you meant to reference #31196 |
…eycloak#31081) Closes keycloak#30821 Signed-off-by: Pedro Igor <pigor.craveiro@gmail.com>
Closes #30821
Closes #31001