Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid deprecated API usage in testsuite/integration-arquillian/util #24870

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Avoid deprecated API usage in testsuite/integration-arquillian/util #24870

merged 1 commit into from
Nov 21, 2023

Conversation

thomasdarimont
Copy link
Contributor

No description provided.

@thomasdarimont
Avoid deprecated API usage in testsuite/integration-arquillian/util
4687bcb 
Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
@thomasdarimont thomasdarimont requested review from a team as code owners November 20, 2023 21:18
@thomasdarimont thomasdarimont requested a review from a team November 20, 2023 21:18
@thomasdarimont thomasdarimont requested a review from a team as a code owner November 20, 2023 21:18
@ghost ghost mentioned this pull request Nov 20, 2023
Closed
ghost
ghost reviewed Nov 20, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ghost
Copy link

ghost commented Nov 20, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.account.WebAuthnTransportLocaleTest#localizationTransportNFC

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected OIDCLogin but was  (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?client_id=account-console&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Ftest%2Faccount%2F%23%2Fsecurity%2Fsigningin&state=e1f0628b-b6b7-4103-bd8d-fbeff5652e35&response_mode=fragment&response_type=code&scope=openid&nonce=0b1fdadf-158f-42ea-8b4a-b6e2c0101aaa&code_challenge=CsJZeF2DrLBxf6lhv3hgIYQJxl57KZMA_cBY6_zPl68&code_challenge_method=S256)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.page.AbstractPage.assertCurrent(AbstractPage.java:110)
	at jdk.internal.reflect.GeneratedMethodAccessor635.invoke(Unknown Source)
...

Report flaky test

ahus1
ahus1 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this code cleanup!

@ahus1 ahus1 merged commit cd1e0e0 into keycloak:main Nov 21, 2023
65 checks passed
ShefeeqPM pushed a commit to ShefeeqPM/keycloak that referenced this pull request Jan 27, 2024
@thomasdarimont @ShefeeqPM
Avoid deprecated API usage in testsuite/integration-arquillian/util (k…
11ab13b 
…eycloak#24870)

Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
Signed-off-by: ShefeeqPM <86718986+ShefeeqPM@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahus1 ahus1 ahus1 approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasdarimont @ahus1