-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle exceptions thrown when requesting storage-access
permission
#21325
Conversation
01b6d9a
to
54e7c01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.ui.account2.WelcomeScreenTest#personalInfoTestKeycloak CI - Account Console IT (firefox)
|
When will it be released? |
|
Adds an error handler when requesting the
storage-access
permission when checking 3rd-party cookie access. If an error is thrown, it falls back to the regular redirect flow to detect 3rd-party cookie support.The Permission API will sometimes throw exceptions when requesting access to storage, specifically in Safari this occurs more than in other browsers (likely it doesn't support the
storage-access
permission yet, see #21307 (comment)). This can result in the iframe timing out, failing the authentication check and leaving client applications in a unusable state.Closes #21307