-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UserQueryProvider interface #20440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vramik
force-pushed
the
20438-UserQueryProvider
branch
from
May 18, 2023 10:23
6d722e8
to
97e06c8
Compare
ghost
added
the
flaky-test
label
May 18, 2023
ghost
mentioned this pull request
May 18, 2023
vramik
force-pushed
the
20438-UserQueryProvider
branch
from
May 26, 2023 15:47
97e06c8
to
a3439d5
Compare
vramik
force-pushed
the
20438-UserQueryProvider
branch
3 times, most recently
from
June 1, 2023 05:28
160006c
to
e4fcb72
Compare
hmlnarik
previously approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
vramik
force-pushed
the
20438-UserQueryProvider
branch
from
June 9, 2023 08:26
e4fcb72
to
c2f7947
Compare
Rebased. |
ghost
mentioned this pull request
Jun 9, 2023
hmlnarik
previously approved these changes
Jun 12, 2023
@vramik Could you please rebase? |
vramik
force-pushed
the
20438-UserQueryProvider
branch
from
June 12, 2023 11:11
c2f7947
to
d718a3f
Compare
ghost
mentioned this pull request
Jun 12, 2023
hmlnarik
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20438