Validate / fix user-storage-jpa #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahus1
requested changes
Mar 15, 2023
There was a problem hiding this comment.
Hi @vramik - thank you for making this work with tests for the Quarkus distribution!
See below for some comment. I didn't find the time to start it manually today; I plan to do this for the next review iteration.
Please see below for some comments.
vramik
force-pushed
the
17391-17392-user-storage-jpa
branch
from
887e282 to
b2454c3
Compare
ahus1
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been two separate quickstarts.
user-storage-jpa-legacywas made for legacy wildfly dist and contained an integration test.user-storage-jpawas modified for quarkus dist, but it didn't have any integration test.The PR merges two quickstarts together.
user-storage-jpa-legacywas removeduser-storage-jpauser-storage-jpawas enabled for GHAuser-storage-jpanow implements non-deprecated methodsCloses keycloak/keycloak#17392
Closes keycloak/keycloak#17391