This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Transition to new channel with soundname included #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnojima
approved these changes
Jul 9, 2018
| NotificationManager manager = | ||
| (NotificationManager) reactContext.getSystemService(reactContext.NOTIFICATION_SERVICE); | ||
| // Delete old notification channel | ||
| manager.deleteNotificationChannel(OLD_CHANNEL_ID); |
There was a problem hiding this comment.
so you tested that this is fine if this doens't exist right
There was a problem hiding this comment.
yep, it worked on a fresh install
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on upgrading & fresh installs. On upgrade users see a little
(i) category deletedthing under the newly created category in settings. Our sound does not get added to the list of available sounds, it shows asApp provided soundbut doesn't show up in the list. So when the user switches the sound away there won't be a way to switch back. I also tested API < 26 and ourdefaultsoundmobilesetting works as expected. r? @keybase/react-hackers