This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Use notification channel on Android #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @keybase/react-hackers but most likely @chrisnojima |
|
Compare to zo0r#657 |
akalin-keybase
commented
Jun 8, 2018
|
|
||
| defaultConfig { | ||
| minSdkVersion 16 | ||
| targetSdkVersion 23 | ||
| targetSdkVersion 28 |
There was a problem hiding this comment.
Had to bump this to 28 to get it to compile
chrisnojima
reviewed
Jun 8, 2018
akalin-keybase
commented
Jun 8, 2018
| @@ -158,7 +158,7 @@ public void sendToNotificationCentre(Bundle bundle) { | |||
| title = context.getPackageManager().getApplicationLabel(appInfo).toString(); | |||
| } | |||
|
|
|||
| NotificationCompat.Builder notification = new NotificationCompat.Builder(context) | |||
| NotificationCompat.Builder notification = new NotificationCompat.Builder(context, RNPushNotification.CHANNEL_ID) | |||
There was a problem hiding this comment.
This is called by RNPushNotificationListenerService.handleRemotePushNotification, which AFAICT is what is called when a GCM push notification is received.
Tested with plaintext notifications both off and on.
|
Yes, this is on top of keybase-fixes-off-302 |
chrisnojima
approved these changes
Jun 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for Android Oreo.
Hard-code channel parameters for now.