Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pre-commit.com hooks for everything #6022

Merged
merged 2 commits into from
Feb 27, 2017
Merged

use pre-commit.com hooks for everything #6022

merged 2 commits into from
Feb 27, 2017

Conversation

maxtaco
Copy link
Contributor

@maxtaco maxtaco commented Feb 24, 2017

  • upgraded pre-commit to reference more lenient go lint
  • remove old pre-commit hook
  • instructions for using the new

- remove old pre-commit hook
- instructions for using the new
@maxtaco maxtaco changed the title upgraded pre-commit to reference more lenient go lint use pre-commit.com hooks for everything Feb 24, 2017
@maxtaco
Copy link
Contributor Author

maxtaco commented Feb 24, 2017

I realize this is a pretty big change in workflow, so calling in reviews from @gabriel, @zanderz and @patrickxb

Copy link
Contributor

@patrickxb patrickxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, i think?

@maxtaco
Copy link
Contributor Author

maxtaco commented Feb 27, 2017

haven't heard back, going to just put this in. @gabriel and @zanderz we can always change it later

@maxtaco maxtaco merged commit 3bf85d0 into master Feb 27, 2017
@maxtaco maxtaco deleted the maxtaco/CORE-4487 branch February 27, 2017 14:57
@slaver84
Copy link

{
"body": {
"key": {
"eldest_kid": "0120aee6799b62e7fcf26794569334bc99dacfad4073ed454586b18eb494073220a90a",
"host": "keybase.io",
"kid": "0120aee6799b62e7fcf26794569334bc99dacfad4073ed454586b18eb494073220a90a",
"uid": "d92cb6aa695a92205bcb874c035e1c19",
"username": "slavian"
},
"merkle_root": {
"ctime": 1568127602,
"hash": "4f2de7fab56dc2aec3b4eb576844d03bbf2d73f59e5ef4d33311e4ca0875a39173796bdac42010807d674d5984d0228663752dc776cbbe1070e356d2fada3d7a",
"hash_meta": "5fe75711597cb9a71b85d5e47211f8a99825a3c0ea6e28ff26875dc108717852",
"seqno": 6434505
},
"service": {
"entropy": "NUTNVckPqyyDLW9flXUkjx1Z",
"name": "github",
"username": "slaver84"
},
"type": "web_service_binding",
"version": 2
},
"client": {
"name": "keybase.io go client",
"version": "4.4.0"
},
"ctime": 1568127647,
"expire_in": 504576000,
"prev": "6183a540c4dc8515dde029c6e9579654d16fe9cdef74bf92f2c6324c1ae90fd0",
"seqno": 9,
"tag": "signature"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants