hacky workaround for zoom not rendering #27573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnojima
commented
Aug 14, 2024
| }) | ||
| const taps = Gesture.Exclusive(doubleTap, singleTap) | ||
|
|
||
| // this is nasty but i need a way to force this component to render correctly. Passing new zoomScale |
Contributor
Author
There was a problem hiding this comment.
there are 2 underyling issues i think with the native component. If the src changes you can get a really weird rendering artifact where it seems like its zoomed in a tremendous amount and you can't zoom out. Fixed this by entirely using a new key on the scale change. (below). On this line we need to 'jiggle' the zoomscale so it'll adopt it. If we don't do this you can log and see the scale is set and passed down but its not respected (the onScroll callback fires but not with this value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.