fix image zoom issues on mobile #27285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnojima
commented
Jul 17, 2024
| }, []) | ||
|
|
||
| // in order for the images to not get downscaled we have to make it larger and then transform it | ||
| const manualScale = 5 |
Contributor
Author
There was a problem hiding this comment.
i think we can skip this
chrisnojima
commented
Jul 23, 2024
|
|
||
| const translationX = useSharedValue(0) | ||
| const translationY = useSharedValue(0) | ||
| const velocityX = useSharedValue(0) |
Contributor
Author
There was a problem hiding this comment.
let it fling like ios a bit
chrisnojima
commented
Jul 23, 2024
| .onStart(() => { | ||
| if (isPinching.value || !isZoomed.value) return | ||
|
|
||
| .averageTouches(true) |
Contributor
Author
There was a problem hiding this comment.
we want the center of touches and not jump around depending on how fingers go up / down
chrisnojima
commented
Jul 23, 2024
| .onUpdate(e => { | ||
| if (isPinching.value || !isZoomed.value) { | ||
| // if we're done panning ignore us letting go | ||
| if (e.numberOfPointers < panFingers.value) { |
Contributor
Author
There was a problem hiding this comment.
this is so when you transition from a pinch to just fingers we don't pan around after, its too jarring
chrisnojima
commented
Jul 23, 2024
| panTranslateX.value = e.translationX | ||
| panTranslateY.value = e.translationY | ||
| } else { | ||
| // imagine what happens to pixels when we zoom in. (they get multiplied by x times scale) |
Contributor
Author
There was a problem hiding this comment.
we don't need this logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.