Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Progress Bar and a few minor tweaks #82

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Style Progress Bar and a few minor tweaks #82

merged 2 commits into from
Jun 25, 2022

Conversation

FredHappyface
Copy link
Contributor

Thank you for an awesome project - was a great starting point for some dev I was doing

This PR adds the following:

  • add dark scrollbar for dark theme
  • consistent hovering (brightness is applied to navbar hovering)
  • style progress bar

(Adapted from changes for some webdev I was doing - https://fhpwa.github.io/. There were some other changes made around theming but I've held off as I'm not sure if that diverges too much from the theming this project aims to do. On the off-chance it would be useful happy to contribute further)

Hope this is useful, any tweaks etc - please let me know

consistent hovering
style progress bar
@netlify
Copy link

netlify bot commented May 5, 2022

Deploy Preview for simplecss-cdn ready!

Name Link
🔨 Latest commit 261c7e0
🔍 Latest deploy log https://app.netlify.com/sites/simplecss-cdn/deploys/627e99e076d80400087ce866
😎 Deploy Preview https://deploy-preview-82--simplecss-cdn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kevquirk
Copy link
Owner

kevquirk commented May 7, 2022

Hey, thanks for this - lots of tidy up that just becomes white noise as I spend so much time in this file. I think Atom automatically cleans up the tabbing, so I don't see that. So appreciate the tidying there.

I don't like the colour changes though - using accent-bg in place of accent for things like buttons isn't what I want, and it would be a breaking change for the sites that use simple.css.

If you remove the changes to the colours, I'll merge the rest.

Thanks,

Kev

@@ -252,8 +254,8 @@ header > nav a:visited {
}

header > nav a:hover {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully addressed your comments. Would you like this reverting too? This was included to provide consistency with other hover items like buttons

@FredHappyface
Copy link
Contributor Author

Hi just dropping a follow up comment here. Happy to make additional changes if needed :)

@kevquirk
Copy link
Owner

Thanks for the prompt - been meaning to re-visit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants