Improve exception handling in Guacamole view & Vpshere

[Kyrd0x]

Summary

Improved exception handling in vsphere.py and the Guacamole view:

• In vsphere.py, added error details to the CuckooCriticalError message for better debugging.
• In guac/views.py, added proper checks to:
  • Ensure libvirt is available before using it
  • Restrict Guacamole usage to compatible machinery types (kvm, qemu)
• Updated the error page template to load static files if needed

These changes help avoid unexpected crashes or misleading behavior when using unsupported backends like vsphere, and improve feedback to the user.

---

This is my first contribution to the project — happy to get any feedback.

[gemini-code-assist]

Summary of Changes

Hello @Kyrd0x, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the robustness and user experience of the Guacamole remote session feature and the vSphere machinery integration. My changes introduce more specific error messages for vSphere connection issues and implement crucial pre-checks within the Guacamole view to handle missing dependencies or unsupported machinery configurations gracefully, providing clearer feedback to the user and preventing unexpected application behavior.

Highlights

• Improved vSphere Error Reporting: I've enhanced the vsphere.py machinery module to include the specific exception details when a connection to the vSphere host fails. This provides more actionable debugging information in CuckooCriticalError messages.
• Guacamole Libvirt Availability Check: I've added a pre-check in guac/views.py to verify if the libvirt library is available. If it's not, the user is now directed to an error page, preventing crashes and providing clear feedback.
• Guacamole Machinery Type Restriction: The Guacamole view in guac/views.py now explicitly checks if the configured machinery type is kvm or qemu. If an unsupported type (like vsphere) is used, an informative error page is displayed to the user.
• Static File Loading for Guacamole Error Page: I've updated the guac/error.html template to correctly load static files, ensuring that the error page renders properly with its intended styling and assets.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request improves exception handling in the Guacamole view and vSphere machinery. The changes include adding error details to the CuckooCriticalError message in vsphere.py, adding checks for libvirt availability and compatible machinery types in guac/views.py, and updating the error page template to load static files. The feedback focuses on improving error logging and resource management.

[doomedraven]

thank you for updates!