FIX: replace <WOOT> with proper env in replace_seabios_clues_public

[MHM98]

There was some place in kvm-qemu.sh script that the <WOOT> was not replaced with proper value.
So i defined an env and replace them accordingly

[gemini-code-assist]

Hello @MHM98, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses an issue in the kvm-qemu.sh script where the placeholder <WOOT> was not consistently replaced with the intended environment variable. To resolve this, I've defined a new environment variable BOCHS_SEABIOS_BLOCK_REPLACER and updated the replace_seabios_clues_public function to use this variable for the replacements, ensuring the script functions as expected.

Highlights

• Bug Fix: The primary focus is to correct the incomplete replacement of <WOOT> in the kvm-qemu.sh script.
• Environment Variable: A new environment variable, BOCHS_SEABIOS_BLOCK_REPLACER, is introduced to handle the Seabios-related replacements.
• Code Clarity: The changes enhance code readability and maintainability by using a dedicated environment variable instead of hardcoding the placeholder.

Changelog

• installer/kvm-qemu.sh
  • Introduced the BOCHS_SEABIOS_BLOCK_REPLACER environment variable.
  • Modified the replace_seabios_clues_public function to use the new environment variable for replacing 'Bochs' and 'BOCHS ' in src/config.h.
  • Ensured that BXPC is replaced with $BXPC_REPLACER in src/config.h.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A script's woe,
<WOOT> must go,
Env'ronment's grace,
Takes its place,
Now the code can truly flow.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new environment variable BOCHS_SEABIOS_BLOCK_REPLACER and updates the replace_seabios_clues_public function to use this and another existing variable for replacing placeholders in configuration files. This is a positive change towards better configurability and maintainability by avoiding hardcoded values. The review focuses on the correctness of these changes, following common shell scripting best practices, as no specific style guide was provided for this repository.

Summary of Findings

• Potential sed search pattern mismatch: A change in the sed search pattern for replacing a "BOCHS"-related string was identified. It's crucial to confirm that the new pattern accurately targets the intended string in src/config.h to ensure the replacement works as expected. This has been detailed in a review comment.
• Code Style: Extra blank lines (Not commented due to review settings): In installer/kvm-qemu.sh, a couple of extra blank lines (lines 137-138 on the right side of the diff) were introduced after the definition of the new BOCHS_SEABIOS_BLOCK_REPLACER variable. While this doesn't affect functionality, removing them would align better with common shell script styling, which typically uses single blank lines to separate logical blocks. This is a low-severity issue and, per review settings, a formal comment was not created.

Merge Readiness

The pull request makes a good step towards improving script configurability. However, there's a potential high-severity issue regarding a sed search pattern change that needs clarification from the author to ensure the script's correctness. I recommend addressing the concern raised in the review comment before merging. As a reviewer, I am not authorized to approve pull requests, so further review and approval by authorized maintainers will be necessary after the feedback is addressed.

[doomedraven]

hello, this is not fully correct, you replace 2 different patterns with just 1, they should have their own replacement patterns