This repository was archived by the owner on Sep 20, 2026. It is now read-only.
Repository navigation
test: verify Phase 2.5 fixes (spaced paths, extraAssets, bootstrap validation) - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the sample app and scenarios to cover the Phase 2.5 fixes in flutter/flutter#193040:
sample_app: spaced-path asset (assets/sub dir/space image.png) probed throughAssetImage, rawrootBundle, andassetManager.getAssetUrl;extra.noticesandextra.frameworkShaderprobes for files resolved via_flutter.buildConfig.extraAssets;manifest.AssetManifestnow assertslistAssets()contains no non-pubspec keys, that the primary variant hasAssetMetadata.main == true, and that spaced keys are not percent-encoded.flutter_bootstrap.jswithout{{flutter_build_config}}(must be refused, error must name the placeholder) and anindex.htmlwithmain.dart.jsinside an HTML comment plus an apostrophe in prose (must build).BuildOptions.keyhashes custom index/bootstrap content so variants don't collide in the build cache.Tool-side runs against flutter/flutter#193040 at
a0fa698d70a(master's prebuilt engine, so runtime probes are not yet meaningful): S10, S12, S13 all PASS. Runtime probes await engine artifacts for the PR.