Development version is now master branch #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed structure to be clearly arranged and to make it usable as module. Updated mqtt_as to not use some workarounds needed for ESP32 with loboris port. Updated README.
removed config dictionary to save ~100-200B which is especially important on esp8266. Moved config dictionary to config.py to still make it possible to configure the library using that dict.
Minimal version for esp8266 saving another 150-250B by removing functions for esp32 and sonoff and by removing not needed functions.
extended class Lock with method locked() returning self._locked to make it more useful outside of mqtt_as
Added misssing documentation about changes made for chaning the way the constructor is called, usage in loboris fork and esp8266 minimal version. Also put all remote_mqtt tests in sepearate folder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this fork is now referenced as an experimental version of the original it makes sense to pull all changes to the master branch.