Skip to content

Replace scrollLock with scroll-snap-type #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Replace scrollLock with scroll-snap-type #140

wants to merge 2 commits into from

Conversation

@kevinfarrugia
Copy link
Owner

@kevinfarrugia kevinfarrugia commented Mar 21, 2023

  • Add .glider-scroll-lock to demo CSS.
  • Replace scrollLock with glider-scroll-lock in demos.
  • Deprecation warnings on scrollLock and scrollLockDelay

@vercel
Copy link

vercel bot commented Mar 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-glider ✅ Ready (Inspect) Visit Preview Mar 21, 2023 at 11:09PM (UTC)

@kevinfarrugia
Copy link
Owner Author

kevinfarrugia commented Mar 21, 2023 •
edited
Loading

  • scroll-snap-type doesn't work well with autoplay as the animation is removed

  • when using the arrows or dots on a glider using scroll-snap, the animation is removed as it snaps immediately to the next/previous element

@kevinfarrugia kevinfarrugia mentioned this pull request Mar 21, 2023
Closed
@kevinfarrugia kevinfarrugia marked this pull request as draft March 20, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinfarrugia