Skip to content

Commit

Permalink
doc(sinks/aws_kinesis): describe partial failure behavior
Browse files Browse the repository at this point in the history
I assumed that these lines meant that failures would be retried but it
does not mean that in many cases, so let's make that explicit and
describe the plans to address the behavior.

Updates vectordotdev#359.
Updates vectordotdev#7659.
Updates vectordotdev#16954.
  • Loading branch information
kevinburkesegment committed Mar 29, 2023
1 parent 0a43987 commit c7aae20
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/sinks/aws_kinesis/streams/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,12 @@ impl RetryLogic for KinesisRetryLogic {

fn is_retriable_error(&self, error: &Self::Error) -> bool {
if let SdkError::ServiceError { err, raw: _ } = error {
// Note that if the request partially fails (records sent to one
// partition fail but the others do not, for example), Vector
// does not retry. This line only covers a failure for the entire
// request.
//
// https://github.com/vectordotdev/vector/issues/359
if let PutRecordsErrorKind::ProvisionedThroughputExceededException(_) = err.kind {
return true;
}
Expand Down

0 comments on commit c7aae20

Please sign in to comment.