fix(aiohttp): Record error responses when raise_for_status is used

[andrescollares]

Fixes #635

Could be a breaking change for those that are using vcrpy with aiohttp and are expecting the library to not record error responses.

[JForsythe99]

Was in the process of writing a fix for this issue myself but just saw that you've already submitted this PR. Looks good to me - I've made a minor refactoring suggestion on your aiohttp stubs code but am happy with your change :)

[andrescollares]

I've been using this branch for a year now and I haven't found any issues with it yet, so I hope someone else can benefit from these changes after merging.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.44%. Comparing base (06758c9) to head (b593fea).
⚠️ Report is 13 commits behind head on master.

Files with missing lines	Patch %	Lines
vcr/stubs/aiohttp_stubs.py	89.47%	1 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
- Coverage   92.71%   92.44%   -0.28%     
==========================================
  Files          27       27              
  Lines        1950     1999      +49     
  Branches      251      258       +7     
==========================================
+ Hits         1808     1848      +40     
- Misses         93       99       +6     
- Partials       49       52       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[JForsythe99]

Looks good, will probably start using this myself

[andrescollares]

Hey @kevin1024 sorry for the tag, I have merge rights but this would be my first PR and it feels weird to just merge it without asking 😬.

[kevin1024]

Merge at will. But we will need to remember to do a major version bump since this is backwards incompatible

[andrescollares]

In that case, do you think it could be a good idea for me to solve a couple more issues that are backwards incompatible? that way maybe we can then release them all together in a single major version bump.

I went through the opened PRs and issues and grabbed some, if you have something that I could help with let me know, in the meantime I'll try to continue with some other aiohttp ones.

[kevin1024]

Sure, we can bundle some together. Thanks for helping. If there are any “greatest hits” tickets with a zillion comments or thumbs up those would be good ones.