Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary FxCtor from loggerf.instances.future.logFuture #473

Closed
kevin-lee opened this issue Sep 5, 2023 · 0 comments · Fixed by #474
Closed

Remove unnecessary FxCtor from loggerf.instances.future.logFuture #473

kevin-lee opened this issue Sep 5, 2023 · 0 comments · Fixed by #474
Assignees
@kevin-lee
Labels
task Task v2
Milestone
v2-m1

Comments

@kevin-lee
Copy link
Owner

Summary

Remove unnecessary FxCtor from loggerf.instances.future.logFuture

Version

2.0.0-beta18

Description

Since loggerf.instances.future.LogFuture can just have effectie.instances.future.fxCtor.fxCtorFuture, it's not required to have EF: FxCtor[Future] as a parameter of loggerf.instances.future.logFuture.
@kevin-lee kevin-lee added this to the v2-m1 milestone Sep 5, 2023
@kevin-lee kevin-lee self-assigned this Sep 5, 2023
kevin-lee added a commit that referenced this issue Sep 5, 2023
@kevin-lee
Close #473 - Remove unnecessary FxCtor from loggerf.instances.future.…
4717b8f 
…logFuture
kevin-lee added a commit that referenced this issue Sep 5, 2023
@kevin-lee
Close #473 - Remove unnecessary FxCtor from loggerf.instances.future.…
57c8249 
…logFuture
@kevin-lee kevin-lee mentioned this issue Sep 5, 2023
Merged
kevin-lee added a commit that referenced this issue Sep 5, 2023
@kevin-lee
Merge pull request #474 from kevin-lee/task/473/clean-up-param
7b87fa2 
Close #473 - Remove unnecessary `FxCtor` from `loggerf.instances.future.logFuture`
@kevin-lee kevin-lee mentioned this issue Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin-lee kevin-lee

Labels
task Task v2
Projects
None yet
Milestone
v2-m1
Development

Successfully merging a pull request may close this issue.

Close #473 - Remove unnecessary FxCtor from loggerf.instances.future.logFuture kevin-lee/logger-f
1 participant
@kevin-lee