-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #502 from kevin-lee/prepare-to-release
- Loading branch information
Showing
2 changed files
with
26 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
## [2.0.0-beta22](https://github.com/kevin-lee/logger-f/issues?q=is%3Aissue+is%3Aclosed+milestone%3Av2-m1+closed%3A2023-10-02..2023-11-07) - 2023-11-08 | ||
|
||
## Change | ||
|
||
* Change the `LogMessage` parameter in the `log(F[A])` method from `NotIgnorable` to `MaybeIgnorable` (#498) | ||
This could be required and useful for case like | ||
|
||
```scala | ||
final case class Something(id: Int, name: String) | ||
|
||
val fa: F[Something] = ... | ||
Log[F].log(fa) { | ||
case Something(0, _) => ignore | ||
case Something(n, name) => info(s"Something: id=$n, name=$name") | ||
} | ||
``` | ||
|
||
## Improvement | ||
|
||
* Remove unnecessary re-evaluation of `String` in `logS` (#500) | ||
`msg()` and `message` (call-by-name) below in line 61 (Scala 2) and line 62 (Scala 3) were replaced with a single lazy evaluation. | ||
|
||
https://github.com/kevin-lee/logger-f/blob/47a0ad183bf4b3b847661143e31a85c302d02146/modules/logger-f-core/shared/src/main/scala-2/loggerf/core/Log.scala#L56-L62 | ||
|
||
https://github.com/kevin-lee/logger-f/blob/47a0ad183bf4b3b847661143e31a85c302d02146/modules/logger-f-core/shared/src/main/scala-3/loggerf/core/Log.scala#L59-L63 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
ThisBuild / version := "2.0.0-SNAPSHOT" | ||
ThisBuild / version := "2.0.0-beta22" |