Skip to content

chore(pr_comments): Use path.join for creating a fs path#124

Merged
algorithmcardboard merged 2 commits intomainfrom
algoboard/chore/pr-comments
Sep 7, 2022
Merged

chore(pr_comments): Use path.join for creating a fs path#124
algorithmcardboard merged 2 commits intomainfrom
algoboard/chore/pr-comments

Conversation

@algorithmcardboard
Copy link
Contributor

Description of this change

Address the pr comments; Also make the build succeed.

Why is this change being made?

  • Chore (non-functional changes)
  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested? How can the reviewer verify your testing?

Locally by running winch ci --dry-run

⋊> ~/s/k/ketch-cli on algoboard/chore/pr-comments ◦ winch ci --dry-run                                                                                                                                                                                            14:50:23
Performing a dry run build
Version: 1.3.1
Prerelease:
Creating changelog
Creating version
Installing
Download modules
go mod download
Building
sh ./scripts/build.sh darwin linux windows
Building for darwin amd64...
|- ketch
|--> copied to ~/go/bin
Building for darwin arm64...
|- ketch
Building for linux amd64...
|- ketch
Building for windows amd64...
|- ketch
⋊> ~/s/k/ketch-cli on algoboard/chore/pr-comments ⨯ ls -l .build/                                                                                                                                                                                                 14:51:12
total 0
drwxr-xr-x  3 anirudhan  staff  96 Sep  6 14:50 darwin-amd64/
drwxr-xr-x  3 anirudhan  staff  96 Sep  6 14:50 darwin-arm64/
drwxr-xr-x  3 anirudhan  staff  96 Sep  6 14:51 linux-amd64/
drwxr-xr-x  3 anirudhan  staff  96 Sep  6 14:51 windows-amd64/
⋊> ~/s/k/ketch-cli on algoboard/chore/pr-comments ⨯ ls -l .build/**/*                                                                                                                                                                                             14:51:20
-rwxr-xr-x  1 anirudhan  staff  13054144 Sep  6 14:50 .build/darwin-amd64/ketch*
-rwxr-xr-x  1 anirudhan  staff  12787506 Sep  6 14:50 .build/darwin-arm64/ketch*
-rwxr-xr-x  1 anirudhan  staff  13232064 Sep  6 14:51 .build/linux-amd64/ketch*
-rwxr-xr-x  1 anirudhan  staff  13578752 Sep  6 14:51 .build/windows-amd64/ketch*

.build/darwin-amd64:
total 25504
-rwxr-xr-x  1 anirudhan  staff  13054144 Sep  6 14:50 ketch*

.build/darwin-arm64:
total 24976
-rwxr-xr-x  1 anirudhan  staff  12787506 Sep  6 14:50 ketch*

.build/linux-amd64:
total 25848
-rwxr-xr-x  1 anirudhan  staff  13232064 Sep  6 14:51 ketch*

.build/windows-amd64:
total 26528
-rwxr-xr-x  1 anirudhan  staff  13578752 Sep  6 14:51 ketch*
⋊> ~/s/k/ketch-cli on algoboard/chore/pr-comments ⨯

Related issues

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have evaluated the security impact of this change, and OWASP Secure Coding Practices have been observed.
  • I have informed stakeholders of my changes.

@algorithmcardboard algorithmcardboard merged commit 2806347 into main Sep 7, 2022
@algorithmcardboard algorithmcardboard deleted the algoboard/chore/pr-comments branch September 7, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants