Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to add prefix icons #54

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

JiteshArul
Copy link

I have added the option to add an icon before text.

  • Ability to use different icons during selection and deselection
  • Ability to use different size of icons
  • Ability to use different colors of icons during selection and deselection
  • Ability to provide padding to the icons

@ketanchoyal ketanchoyal changed the base branch from master to dev January 31, 2022 19:00
@ketanchoyal
Copy link
Owner

Hey @JiteshArul thanks for this awesome PR, I'll have a look at it and merge it if it doesn't break existing code

@JiteshArul
Copy link
Author

Hey @ketanchoyal Thanks for making this package. I found it really useful in my projects and in my learning progress. So I thought of adding some more functionality and make it more customizable. Please feel free to reach out incase of any errors, I would be happy to fix it.

@ketanchoyal
Copy link
Owner

@JiteshArul, Thanks for your PR but your code is breaking lot of previous work, I would suggest taking a look at the final output by running your code and mine

@JiteshArul
Copy link
Author

@JiteshArul, Thanks for your PR but your code is breaking lot of previous work, I would suggest taking a look at the final output by running your code and mine

Thank you for letting me know regarding this issue. I'll try to make it work as soon as possible.

@alexodus
Copy link

any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants