chore: remove the usage of the DefaultRunContext #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🧪 Java Unit Tests
|
Malaydewangan09
approved these changes
Dec 2, 2025
fdelbrayelle
reviewed
Dec 2, 2025
| version=1.3.1-SNAPSHOT | ||
| kestraVersion=1.0.0 | ||
| version=1.4.0-SNAPSHOT | ||
| kestraVersion=1.2.0-SNAPSHOT |
Contributor
There was a problem hiding this comment.
All those 1.2.0 updates here and there prevent us to do any release of these plugins before start of January :(
fdelbrayelle
reviewed
Dec 2, 2025
|
|
||
| try (KubernetesClient client = PodService.client(runContext, this.getConnection()); | ||
| PodLogService podLogService = new PodLogService(((DefaultRunContext) runContext).getApplicationContext().getBean(ThreadMainFactoryBuilder.class))) { | ||
| PodLogService podLogService = new PodLogService()) { |
Contributor
There was a problem hiding this comment.
This has to be reported to EE K8s plugin
fdelbrayelle
requested changes
Dec 2, 2025
Contributor
fdelbrayelle
left a comment
fdelbrayelle
left a comment
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.