Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/remove memory runner #3948

Merged
merged 11 commits into from
Jun 12, 2024
Merged

Feat/remove memory runner #3948

merged 11 commits into from
Jun 12, 2024

Conversation

brian-mulier-p
Copy link
Member

@brian-mulier-p brian-mulier-p commented Jun 6, 2024

A lot going on here. I had some troubles to deal with:

  • had to populate tables class mapping if not present for memory runner to run out-of-the-box
  • indexers weren't all services and the implementation of the MemoryRunner was checking for every queue to be currently polling. I believe it was done because the produce method triggered the consumer so if the receive was not there it would fail and after second-thought it's probably not needed for that change. Still I think it's better to have a blocking run method, we can remove that I don't mind
  • server-type was mandatory for plenty of reasons: if not the livenessService bean would not pop up and crash the app. I made it optional as all tests that are memory-runner based don't provide one although for production it might not be ideal idk

Basically:
runner-memory implements memory-repository (includes some auto-configuration) implements h2
on EE runner-memory-ee implements runner-memory (so all the chain above) + h2-ee to embed the migrations from EE

LAST ISSUE FOR TRANSPARENT MEMORY RUNNER:
@MicronautTest(transactional = false) is now needed or the queue won't work so I'm not sure how to deal with that :'(

EDIT:
The solution taken (and after discussion with Ludo) is to create a @KestraTest annotation that will expose and act the same as @MicronautTest but with transactional being false by default. This will also go along the Micronaut removal from plugins

@brian-mulier-p brian-mulier-p force-pushed the feat/remove-memory-runner branch 5 times, most recently from 31af25b to 171d62a Compare June 7, 2024 17:38
@brian-mulier-p brian-mulier-p force-pushed the feat/remove-memory-runner branch 6 times, most recently from c57cac1 to c1b639b Compare June 10, 2024 14:34
@brian-mulier-p
Copy link
Member Author

StandaloneCommand -> 1 MIN CONFIGURABLE

@brian-mulier-p brian-mulier-p force-pushed the feat/remove-memory-runner branch 5 times, most recently from c8cb212 to 8dbed74 Compare June 12, 2024 10:00
@brian-mulier-p brian-mulier-p force-pushed the feat/remove-memory-runner branch from 42ecb75 to b3821d9 Compare June 12, 2024 15:28
brian-mulier-p added a commit to kestra-io/plugin-solace that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-pulsar that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-azure that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-kafka that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-redis that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-mqtt that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-amqp that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-nats that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-aws that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-fs that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-fs that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-fs that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-notifications that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-elasticsearch that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-kubernetes that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-servicenow that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-fivetran that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-debezium that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-debezium that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-airbyte that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-powerbi that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-scripts that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-docker that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-jdbc that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-jdbc that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-dbt that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-git that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-gcp that referenced this pull request Jun 12, 2024
brian-mulier-p added a commit to kestra-io/plugin-gcp that referenced this pull request Jun 12, 2024
shrutimantri pushed a commit to shrutimantri/plugin-databricks that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant