Skip to content

Commit

Permalink
r8169: remove 1000/Half from supported modes
Browse files Browse the repository at this point in the history
MAC on the GBit versions supports 1000/Full only, however the PHY
partially claims to support 1000/Half. So let's explicitly remove
this mode.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
hkallweit authored and davem330 committed May 30, 2019
1 parent 2c1d029 commit a6851c6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/net/ethernet/realtek/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -6386,7 +6386,10 @@ static int r8169_phy_connect(struct rtl8169_private *tp)
if (ret)
return ret;

if (!tp->supports_gmii)
if (tp->supports_gmii)
phy_remove_link_mode(phydev,
ETHTOOL_LINK_MODE_1000baseT_Half_BIT);
else
phy_set_max_speed(phydev, SPEED_100);

phy_support_asym_pause(phydev);
Expand Down

0 comments on commit a6851c6

Please sign in to comment.