Skip to content

Commit

Permalink
net: dsa: Copy the routing table into the switch structure
Browse files Browse the repository at this point in the history
The new binding will not have a chip data structure, it will place the
routing directly into the switch structure. To enable backwards
compatibility, copy the routing from the chip data into the switch
structure.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
lunn authored and davem330 committed Jun 4, 2016
1 parent 4a7704f commit 66472fc
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
4 changes: 2 additions & 2 deletions drivers/net/dsa/mv88e6xxx.c
Original file line number Diff line number Diff line change
Expand Up @@ -3024,8 +3024,8 @@ static int mv88e6xxx_setup_global(struct mv88e6xxx_priv_state *ps)
for (i = 0; i < 32; i++) {
int nexthop = 0x1f;

if (i != ps->ds->index && i < ps->ds->dst->pd->nr_chips)
nexthop = ps->ds->cd->rtable[i] & 0x1f;
if (i != ds->index && i < DSA_MAX_SWITCHES)
nexthop = ds->rtable[i] & 0x1f;

err = _mv88e6xxx_reg_write(
ps, REG_GLOBAL2,
Expand Down
9 changes: 8 additions & 1 deletion include/net/dsa.h
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,13 @@ struct dsa_switch {
*/
struct dsa_switch_driver *drv;

/*
* An array of which element [a] indicates which port on this
* switch should be used to send packets to that are destined
* for switch a. Can be NULL if there is only one switch chip.
*/
s8 rtable[DSA_MAX_SWITCHES];

#ifdef CONFIG_NET_DSA_HWMON
/*
* Hardware monitoring information
Expand Down Expand Up @@ -194,7 +201,7 @@ static inline u8 dsa_upstream_port(struct dsa_switch *ds)
if (dst->cpu_switch == ds->index)
return dst->cpu_port;
else
return ds->cd->rtable[dst->cpu_switch];
return ds->rtable[dst->cpu_switch];
}

struct switchdev_trans;
Expand Down
2 changes: 2 additions & 0 deletions net/dsa/dsa.c
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,8 @@ static int dsa_switch_setup_one(struct dsa_switch *ds, struct device *parent)
dst->tag_protocol = drv->tag_protocol;
}

memcpy(ds->rtable, cd->rtable, sizeof(ds->rtable));

/*
* Do basic register setup.
*/
Expand Down

0 comments on commit 66472fc

Please sign in to comment.