Skip to content

Commit

Permalink
media: Revert "media: saa7146: deprecate hexium_gemini/orion, mxb and…
Browse files Browse the repository at this point in the history
… ttpci"

This reverts commit e33fdb5.

The saa7146-based devices are still in use, esp. for DVB. So move
these drivers back to mainline.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
  • Loading branch information
Hans Verkuil committed Feb 9, 2023
1 parent 0fcb867 commit 39d08ab
Show file tree
Hide file tree
Showing 35 changed files with 31 additions and 65 deletions.
4 changes: 3 additions & 1 deletion MAINTAINERS
Original file line number Diff line number Diff line change
Expand Up @@ -18393,7 +18393,9 @@ M: Hans Verkuil <hverkuil@xs4all.nl>
L: linux-media@vger.kernel.org
S: Maintained
T: git git://linuxtv.org/media_tree.git
F: drivers/staging/media/deprecated/saa7146/
F: drivers/media/common/saa7146/
F: drivers/media/pci/saa7146/
F: include/media/drv-intf/saa7146*

SAFESETID SECURITY MODULE
M: Micah Morton <mortonm@chromium.org>
Expand Down
1 change: 1 addition & 0 deletions drivers/media/common/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ config VIDEO_TVEEPROM
depends on I2C

source "drivers/media/common/b2c2/Kconfig"
source "drivers/media/common/saa7146/Kconfig"
source "drivers/media/common/siano/Kconfig"
source "drivers/media/common/v4l2-tpg/Kconfig"
source "drivers/media/common/videobuf2/Kconfig"
2 changes: 1 addition & 1 deletion drivers/media/common/Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# SPDX-License-Identifier: GPL-2.0-only
obj-y += b2c2/ siano/ v4l2-tpg/ videobuf2/
obj-y += b2c2/ saa7146/ siano/ v4l2-tpg/ videobuf2/

# Please keep it alphabetically sorted by Kconfig name
# (e. g. LC_ALL=C sort Makefile)
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <media/drv-intf/saa7146.h>
#include <linux/module.h>
#include "saa7146.h"

static int saa7146_num;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// SPDX-License-Identifier: GPL-2.0-only
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <media/drv-intf/saa7146_vv.h>
#include <linux/module.h>
#include "saa7146_vv.h"

/****************************************************************************/
/* resource management functions, shamelessly stolen from saa7134 driver */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

#include <linux/kernel.h>
#include <linux/export.h>
#include "saa7146_vv.h"
#include <media/drv-intf/saa7146_vv.h>

static void calculate_output_format_register(struct saa7146_dev* saa, u32 palette, u32* clip_format)
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include "saa7146_vv.h"
#include <media/drv-intf/saa7146_vv.h>

static u32 saa7146_i2c_func(struct i2c_adapter *adapter)
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
#include "saa7146_vv.h"
#include <media/drv-intf/saa7146_vv.h>

static int vbi_pixel_to_capture = 720 * 2;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

#include <media/drv-intf/saa7146_vv.h>
#include <media/v4l2-event.h>
#include <media/v4l2-ctrls.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include "saa7146_vv.h"

static int max_memory = 32;

Expand Down
2 changes: 2 additions & 0 deletions drivers/media/pci/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ if MEDIA_ANALOG_TV_SUPPORT

source "drivers/media/pci/dt3155/Kconfig"
source "drivers/media/pci/ivtv/Kconfig"
source "drivers/media/pci/saa7146/Kconfig"

endif

Expand Down Expand Up @@ -57,6 +58,7 @@ source "drivers/media/pci/pluto2/Kconfig"
source "drivers/media/pci/pt1/Kconfig"
source "drivers/media/pci/pt3/Kconfig"
source "drivers/media/pci/smipcie/Kconfig"
source "drivers/media/pci/ttpci/Kconfig"

endif

Expand Down
4 changes: 3 additions & 1 deletion drivers/media/pci/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,16 @@

# Please keep it alphabetically sorted by directory
# (e. g. LC_ALL=C sort Makefile)
obj-y += b2c2/ \
obj-y += ttpci/ \
b2c2/ \
pluto2/ \
dm1105/ \
pt1/ \
pt3/ \
mantis/ \
ngene/ \
ddbridge/ \
saa7146/ \
smipcie/ \
netup_unidvb/ \
intel/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,35 +1,29 @@
# SPDX-License-Identifier: GPL-2.0-only
config VIDEO_HEXIUM_GEMINI
tristate "Hexium Gemini frame grabber (DEPRECATED)"
tristate "Hexium Gemini frame grabber"
depends on PCI && VIDEO_DEV && I2C
select VIDEO_SAA7146_VV
help
This is a video4linux driver for the Hexium Gemini frame
grabber card by Hexium. Please note that the Gemini Dual
card is *not* fully supported.

This driver is deprecated and is scheduled for removal by
the beginning of 2023. See the TODO file for more information.

To compile this driver as a module, choose M here: the
module will be called hexium_gemini.

config VIDEO_HEXIUM_ORION
tristate "Hexium HV-PCI6 and Orion frame grabber (DEPRECATED)"
tristate "Hexium HV-PCI6 and Orion frame grabber"
depends on PCI && VIDEO_DEV && I2C
select VIDEO_SAA7146_VV
help
This is a video4linux driver for the Hexium HV-PCI6 and
Orion frame grabber cards by Hexium.

This driver is deprecated and is scheduled for removal by
the beginning of 2023. See the TODO file for more information.

To compile this driver as a module, choose M here: the
module will be called hexium_orion.

config VIDEO_MXB
tristate "Siemens-Nixdorf 'Multimedia eXtension Board' (DEPRECATED)"
tristate "Siemens-Nixdorf 'Multimedia eXtension Board'"
depends on PCI && VIDEO_DEV && I2C
select VIDEO_SAA7146_VV
select VIDEO_TUNER
Expand All @@ -41,8 +35,5 @@ config VIDEO_MXB
This is a video4linux driver for the 'Multimedia eXtension Board'
TV card by Siemens-Nixdorf.

This driver is deprecated and is scheduled for removal by
the beginning of 2023. See the TODO file for more information.

To compile this driver as a module, choose M here: the
module will be called mxb.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

#define DEBUG_VARIABLE debug

#include <media/drv-intf/saa7146_vv.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include "../common/saa7146_vv.h"

static int debug;
module_param(debug, int, 0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

#define DEBUG_VARIABLE debug

#include <media/drv-intf/saa7146_vv.h>
#include <linux/module.h>
#include <linux/kernel.h>
#include "../common/saa7146_vv.h"

static int debug;
module_param(debug, int, 0);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@

#define DEBUG_VARIABLE debug

#include <media/drv-intf/saa7146_vv.h>
#include <media/tuner.h>
#include <media/v4l2-common.h>
#include <media/i2c/saa7115.h>
#include <linux/module.h>
#include <linux/kernel.h>

#include "../common/saa7146_vv.h"
#include "tea6415c.h"
#include "tea6420.h"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config DVB_BUDGET_CORE
tristate "SAA7146 DVB cards (aka Budget, Nova-PCI) (DEPRECATED)"
tristate "SAA7146 DVB cards (aka Budget, Nova-PCI)"
depends on DVB_CORE && PCI && I2C
select VIDEO_SAA7146
select TTPCI_EEPROM
Expand All @@ -10,7 +10,7 @@ config DVB_BUDGET_CORE
MPEG2 decoder.

config DVB_BUDGET
tristate "Budget cards (DEPRECATED)"
tristate "Budget cards"
depends on DVB_BUDGET_CORE && I2C
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
select DVB_VES1X93 if MEDIA_SUBDRV_AUTOSELECT
Expand All @@ -30,16 +30,13 @@ config DVB_BUDGET
or Nova-PCI cards) without onboard MPEG2 decoder, and without
analog inputs or an onboard Common Interface connector.

This driver is deprecated and is scheduled for removal by
the beginning of 2023. See the TODO file for more information.

Say Y if you own such a card and want to use it.

To compile this driver as a module, choose M here: the
module will be called budget.

config DVB_BUDGET_CI
tristate "Budget cards with onboard CI connector (DEPRECATED)"
tristate "Budget cards with onboard CI connector"
depends on DVB_BUDGET_CORE && I2C
select DVB_STV0297 if MEDIA_SUBDRV_AUTOSELECT
select DVB_STV0299 if MEDIA_SUBDRV_AUTOSELECT
Expand All @@ -60,16 +57,13 @@ config DVB_BUDGET_CI
Note: The Common Interface is not yet supported by this driver
due to lack of information from the vendor.

This driver is deprecated and is scheduled for removal by
the beginning of 2023. See the TODO file for more information.

Say Y if you own such a card and want to use it.

To compile this driver as a module, choose M here: the
module will be called budget-ci.

config DVB_BUDGET_AV
tristate "Budget cards with analog video inputs (DEPRECATED)"
tristate "Budget cards with analog video inputs"
depends on DVB_BUDGET_CORE && I2C
select VIDEO_SAA7146_VV
depends on VIDEO_DEV # dependencies of VIDEO_SAA7146_VV
Expand All @@ -86,9 +80,6 @@ config DVB_BUDGET_AV
(so called Budget- or Nova-PCI cards) without onboard
MPEG2 decoder, but with one or more analog video inputs.

This driver is deprecated and is scheduled for removal by
the beginning of 2023. See the TODO file for more information.

Say Y if you own such a card and want to use it.

To compile this driver as a module, choose M here: the
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include "tda1004x.h"
#include "tua6100.h"
#include "dvb-pll.h"
#include "../common/saa7146_vv.h"
#include <media/drv-intf/saa7146_vv.h>
#include <linux/module.h>
#include <linux/errno.h>
#include <linux/slab.h>
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
#include <linux/module.h>
#include <linux/mutex.h>

#include "../common/saa7146.h"
#include <media/drv-intf/saa7146.h>

extern int budget_debug;

Expand Down
1 change: 0 additions & 1 deletion drivers/staging/media/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ menuconfig STAGING_MEDIA_DEPRECATED

if STAGING_MEDIA_DEPRECATED
source "drivers/staging/media/deprecated/atmel/Kconfig"
source "drivers/staging/media/deprecated/saa7146/Kconfig"
endif

endif
1 change: 0 additions & 1 deletion drivers/staging/media/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ obj-$(CONFIG_VIDEO_SUNXI) += sunxi/
obj-$(CONFIG_VIDEO_TEGRA) += tegra-video/
obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3/
obj-$(CONFIG_DVB_AV7110) += av7110/
obj-y += deprecated/saa7146/
3 changes: 1 addition & 2 deletions drivers/staging/media/av7110/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,5 @@ obj-$(CONFIG_DVB_SP8870) += sp8870.o

ccflags-y += -I $(srctree)/drivers/media/dvb-frontends
ccflags-y += -I $(srctree)/drivers/media/tuners
ccflags-y += -I $(srctree)/drivers/media/pci/ttpci
ccflags-y += -I $(srctree)/drivers/media/common
ccflags-y += -I $(srctree)/drivers/staging/media/deprecated/saa7146/ttpci
ccflags-y += -I $(srctree)/drivers/staging/media/deprecated/saa7146/common
2 changes: 1 addition & 1 deletion drivers/staging/media/av7110/av7110.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "stv0297.h"
#include "l64781.h"

#include "saa7146_vv.h"
#include <media/drv-intf/saa7146_vv.h>


#define ANALOG_TUNER_VES1820 1
Expand Down
4 changes: 0 additions & 4 deletions drivers/staging/media/deprecated/saa7146/Kconfig

This file was deleted.

2 changes: 0 additions & 2 deletions drivers/staging/media/deprecated/saa7146/Makefile

This file was deleted.

7 changes: 0 additions & 7 deletions drivers/staging/media/deprecated/saa7146/saa7146/TODO

This file was deleted.

7 changes: 0 additions & 7 deletions drivers/staging/media/deprecated/saa7146/ttpci/TODO

This file was deleted.

File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
#include <media/v4l2-common.h>
#include <media/v4l2-ioctl.h>
#include <media/v4l2-fh.h>
#include <media/drv-intf/saa7146.h>
#include <media/videobuf-dma-sg.h>
#include "saa7146.h"

#define MAX_SAA7146_CAPTURE_BUFFERS 32 /* arbitrary */
#define BUFFER_TIMEOUT (HZ/2) /* 0.5 seconds */
Expand Down

0 comments on commit 39d08ab

Please sign in to comment.