kernelci: api: helper: recurse through ancestors for evaluating rules #2949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-wai
force-pushed
the
rules-recurse-ancestors
branch
2 times, most recently
from
4a1c6ca to
38105a2
Compare
We used to check rules against the node being created and its direct parent. With the addition of post-processing nodes for test jobs, this is no longer sufficient as job `nodes` are lacking some of the fields contained in `kbuild` nodes. Fix this by looking recursively at all ancestors. Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
a-wai
force-pushed
the
rules-recurse-ancestors
branch
from
38105a2 to
5cbb801
Compare
|
Successfully tested on staging: see e.g. this node being created on a non-coverage-enabled build before this PR was deployed to staging, which didn't show up since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to check rules against the node being created and its direct parent. With the addition of post-processing nodes for test jobs, this is no longer sufficient as job
nodesare lacking some of the fields contained inkbuildnodes. Fix this by looking recursively at all ancestors.