config: runtime: tests: tast: enable code coverage support #2940
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft for now as it needs more testing on staging (only manually tested by hand-editing job definitions in LAVA so far) |
Other tests for which we enabled code coverage support run directly on the DUT and are therefore easy to process using additional common test definitions. However, for Tast tests, we execute commands from a container and need to use SSH for executing commands on the DUT which actually runs ChromeOS. For this reason, we can't re-use the existing gcov-related utility templates for Tast test and need to re-implement the whole logic separately: * provide scripts for: * resetting coverage data before running the test * packing coverage data once the test is complete * copy those scripts to the DUT using SCP and execute them when needed through SSH * retrieve coverage data from DUT and upload it to storage All those commands need to be fail-safe, hence the (ab)use of `|| true` so we end up proprely shutting down the DUT (not doing so leads to filesystem corruption, requiring the DUT to be reflashed). Signed-off-by: Arnaud Ferraris <arnaud.ferraris@collabora.com>
a-wai
force-pushed
the
tast-coverage-support
branch
from
33af620 to
2725ea2
Compare
|
Note: previous version (which downloaded the scripts from the internet) has been successfully tested on staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other tests for which we enabled code coverage support run directly on the DUT and are therefore easy to process using additional common test definitions. However, for Tast tests, we execute commands from a container and need to use SSH for executing commands on the DUT which actually runs ChromeOS.
For this reason, we can't re-use the existing gcov-related utility templates for Tast test and need to re-implement the whole logic separately:
All those commands need to be fail-safe, hence the (ab)use of
|| trueso we end up proprely shutting down the DUT (not doing so leads to filesystem corruption, requiring the DUT to be reflashed).