bpf: verifier improvement in 32bit shift sign extension pattern #10411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: ff34657 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
886a6a6 to
4eeea58
Compare
Author
|
Upstream branch: ff34657 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
2516da2 to
0296e9c
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
4eeea58 to
a9395d7
Compare
Author
|
Upstream branch: 8f7aa3d |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
0296e9c to
c99e2b0
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
a9395d7 to
c320ac6
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
c99e2b0 to
c08ae02
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c320ac6 to
d24fc80
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
c08ae02 to
6babdee
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
d24fc80 to
155b58a
Compare
Author
|
Upstream branch: 835a507 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
6babdee to
b789d50
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
155b58a to
942f7c3
Compare
Author
|
Upstream branch: 81f88f6 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
b789d50 to
3a65a3f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
942f7c3 to
caaaee4
Compare
Author
|
Upstream branch: 5d9fb42 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
3a65a3f to
ae23451
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
caaaee4 to
0f1145d
Compare
Author
|
Upstream branch: 5d9fb42 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
ae23451 to
ec1d4a5
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
0f1145d to
fabb672
Compare
This patch improves the verifier to correctly compute bounds for sign extension compiler pattern composed of left shift by 32bits followed by a sign right shift by 32bits. Pattern in the verifier was limitted to positive value bounds and would reset bound computation for negative values. New code allows both positive and negative values for sign extension without compromising bound computation and verifier to pass. This change is required by GCC which generate such pattern, and was detected in the context of systemd, as described in the following GCC bugzilla: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=119731 Three new tests were added in verifier_subreg.c. Signed-off-by: Cupertino Miranda <cupertino.miranda@oracle.com> Signed-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com> Acked-by: Eduard Zingerman <eddyz87@gmail.com> Cc: David Faust <david.faust@oracle.com> Cc: Jose Marchesi <jose.marchesi@oracle.com> Cc: Elena Zannoni <elena.zannoni@oracle.com>
This commit adds 3 tests to verify a common compiler generated pattern for sign extension (r1 <<= 32; r1 s>>= 32). The tests make sure the register bounds are correctly computed both for positive and negative register values. Signed-off-by: Cupertino Miranda <cupertino.miranda@oracle.com> Signed-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com> Acked-by: Eduard Zingerman <eddyz87@gmail.com> Cc: David Faust <david.faust@oracle.com> Cc: Jose Marchesi <jose.marchesi@oracle.com> Cc: Elena Zannoni <elena.zannoni@oracle.com>
Author
|
Upstream branch: c93c124 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/1029813=>bpf-next
branch
from
ec1d4a5 to
1402d63
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
fabb672 to
3119ae5
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1029813 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: verifier improvement in 32bit shift sign extension pattern
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1029813